Skip to content

Add flags to make App.framework work in app extension #123618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 28, 2023
Merged

Add flags to make App.framework work in app extension #123618

auto-submit merged 2 commits into from
Mar 28, 2023

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 28, 2023

When linking or compiling App.framework for iOS or macOS add the -fapplication-extension flag which marks the executable as "safe" to use in an iOS or macOS app extension.

Part of #16092

See https://flutter.dev/go/app-extensions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Mar 28, 2023
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 28, 2023
@jmagman jmagman marked this pull request as ready for review March 28, 2023 20:28
@jmagman jmagman requested a review from cyanglaz March 28, 2023 20:28
cyanglaz
cyanglaz approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
What does App.framework do? (As opposed to flutter.framework)

@jmagman
Copy link
Member Author

jmagman commented Mar 28, 2023

LGTM. What does App.framework do? (As opposed to flutter.framework)

Flutter.framework is the precompiled engine we ship in the SDK. App.framework is the app's compiled dart code. In debug JIT mode the App.framework/App (35KB) is a dummy binary that satisfies the structure of a framework and only contains:

flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart

Line 662 in 5b20589

static const int Moo = 88;

the actual compiled binary is at App.framework/flutter_assets/kernel_blob.bin (39MB) plus the isolate_snapshot_data (5MB).

In release AOT the code is actually compiled to App.framework/App (8.4MB) and there is no kernel_blob.bin or isolate_snapshot_data.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@auto-submit auto-submit bot merged commit 6e5a530 into flutter:master Mar 28, 2023
@jmagman jmagman deleted the app-extension-tool branch March 28, 2023 23:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
9657dad 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
deece2e 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
d7f5f11 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
fe2125c 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
eda9833 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
396b26b 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
3a025b7 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
92c405b 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
8761697 
…r/flutter#123618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
6365284 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
a9c51c7 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
a4db66d 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
70945be 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
6d7224d 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
0527853 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
848add0 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
eac57bd 
…r/flutter#123618)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
d4a3e7c 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
0168d5c 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
518dc6b 
…r/flutter#123618)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
4ffec63 
…r/flutter#123618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6e5a530 Add flags to make App.framework work in app extension (flutte…
dd7939b 
…r/flutter#123618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @cyanglaz