Add spell check TextSpan creation logic that doesn't rely on composing region #123481

camsim99 · 2023-03-25T23:52:24Z

Fixes #119534 by adding extra logic to allow the proper TextSpan trees to be build with spell check results that does not rely on the composing region.

Also, refreshes the algorithm used to correct spell check results to improve cases where spell check results are out of date, but the composing region line does not help smooth over this fact by giving the framework extra time to update while a word is being composed (because a composing region line would cover up any flashing red underlines).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

justinmc

Overall the approach in _buildSubtreesWithoutComposingRegion looks good to me, but two things I'm wondering about:

Is it also responsible for drawing the composing region? Say if you use a Chinese composing IME on Android with Gboard, will it get routed through _buildSubtreesWithoutComposingRegion and the composing region won't draw? Or maybe this is handled somewhere and there's nothing to worry about.
Depending on the answer to the above, it feels like we might be able to share a lot of the code between _buildSubtreesWithComposingRegion and _buildSubtreesWithoutComposingRegion. It seems like the fundamental difference between these two methods is just how we detect the word that's currently being edited. Maybe there is more about drawing the composing region that needs to be different, though.

justinmc · 2023-03-29T21:49:18Z

packages/flutter/lib/src/widgets/spell_check.dart

-  return TextSpan(
+  // We will draw the TextSpan tree based on the composing region, if it is
+  // available.
+  final bool shouldConsiderComposingRegion = defaultTargetPlatform == TargetPlatform.android;


Maybe add a comment here describing the fact that Gboard is what considers the composing region, and other Android keyboards may not be compatible with this.

Also we should try using spell check with a newer Samsung device and the Samsung keyboard and see what happens. It won't work, but ideally it would fail silently or maybe even log a warning rather than crash.

I asked about TargetPlatform.android including Samsung because I don't understand why this would crash? Does the Samsung keyboard not have a composing region? If so, I didn't realize that.

I still need to test this, but it should not be a problem because in addition to this check, I can just check if the composing region is valid before using the method that considers it.

It does have a composing region, it just doesn't use it for the current editing word (as far as I know). Maybe I'm too pessimistic. I thought the Samsung keyboard wasn't compatible at the engine level or something. If it works then that's great.

justinmc · 2023-03-29T21:50:12Z

packages/flutter/lib/src/widgets/spell_check.dart

+
+  return TextSpan(
+    style: style,
+    children: _buildSubtreesWithoutComposingRegion(


What exactly happens if you use this method on Android with Gboard?

I just tried it: It works the same, but the composing region doesn't draw. I think that's expected behavior!

That makes me think that we could use only this method and get rid of the other one. It could remove the composing region when it's part of the replaced word and then draw it. Maybe in another PR if that's going to delay this one, though.

I definitely think that they can be merged into one and is worth pursuing, then. I am running short on time, though, so unless you're open to playing around with it, I say we delay it for now and file an issue!

I'm on board with filing an issue for later 👍

packages/flutter/lib/src/widgets/spell_check.dart

camsim99 · 2023-03-31T17:17:59Z

Is it also responsible for drawing the composing region? Say if you use a Chinese composing IME on Android with Gboard, will it get routed through _buildSubtreesWithoutComposingRegion and the composing region won't draw? Or maybe this is handled somewhere and there's nothing to worry about.

Depending on the answer to the above, it feels like we might be able to share a lot of the code between _buildSubtreesWithComposingRegion and _buildSubtreesWithoutComposingRegion. It seems like the fundamental difference between these two methods is just how we detect the word that's currently being edited. Maybe there is more about drawing the composing region that needs to be different, though.

It's not responsible for drawing the composing region at all, but it does ignore the word the cursor is touching. However, if it's running on an Android device, if won't call that method, so the problem you described in # 1 should not be a problem, unless I'm misunderstanding what you're asking.

Nonetheless, we can probably share some code between the two, although detecting the cursor index to ignore the misspelled word is much simpler logic than dealing with the composing region, so I think some readability would be lost. I would rather not spend time on this now though since I have limited time and I want to focus on getting this landed in time, unless you think it's high priority. Just lmk!

justinmc · 2023-03-31T17:22:18Z

Sounds good, as long as the composing region is being drawn the the code reuse thing is secondary.

camsim99 · 2023-03-31T17:24:48Z

Sounds good, as long as the composing region is being drawn the the code reuse thing is secondary.

Okay. Does TargetPlatform.android pick up Samsung? If I remember correctly, Samsung does also pick up the composing region, so this should funnel it towards the method that would draw it!

justinmc · 2023-03-31T17:26:24Z

Yes, a Samsung Android device will have defaultTargetPlatform == TargetPlatform.android. However, there is no way in the framework to know if it is specifically Samsung or not.

camsim99 · 2023-03-31T17:26:54Z

Yes, a Samsung Android device will have defaultTargetPlatform == TargetPlatform.android. However, there is no way in the framework to know if it is specifically Samsung or not.

Okay, gotcha. I will make sure to test this on one today.

camsim99 · 2023-03-31T18:42:36Z

packages/flutter/lib/src/widgets/spell_check.dart

+          // Adjust offset to reflect the difference between where currentSpan
+          // was positioned in resultsText versus where the modified version
+          // is positioned in newText.
+          offset = (adjustedSpanEnd - adjustedSpanStart) - (currentSpan.range.end - currentSpan.range.start) + (adjustedSpanStart - currentSpan.range.start);


The one thing I still want to think about a little more is whether or not to calculate offset this way. The rest of the method assumes really only that one modification has been made between resultsText and newText, and while it may account for more cases than that, this explicitly allows for two operations: modification and movement.

Thinking about this more, this algorithm covers the following cases:

One or more SuggestionSpan shifts, e.g. "Hlello, wrold" --> "Hlello, beautiful wrold" or --> "Oh! Hlello, big, beautiful wrold"*

One or more SuggestionSpan modifications, e.g. "Hello, wrold" --> "Hello, wroldd" or --> "Helllo, wroldd"

One or more SuggestionSpan shifts or modifications, e.g. "Hello, wrold" --> "Hello, big wroldd"

This should be all of the cases that we need to consider because we only care about finding the SuggestionSpan text coming from the old text (resultsText) in the new text, which means that we only care about shifts and modifications of that SuggestionSpan text. Calculating the offset this way in this case, means that we catch case 2 and 3. Case 1 is caught above in the code by adjusting offset based on the actual foundIndex of the SuggestionSpan text. Thus, the code does not at all assume that only one modification has been made, and I believe it is fine as is. I still think multiple modifications/shifts is unlikely, but it doesn't hurt to cover that case.

*Note that all my examples use insertions but deletions for shifts should be accounted for, as well.

How are you able to do cases 2 and 3? If I'm understanding correctly, those show that a misspelled word has been modified (wrold to wroldd), and you're still able to correct it (world)? That seems super tricky if I'm understanding it correctly. It might be better to not handle those at all. What if the modification creates a correctly spelled word (worl to worlds)?

Not quite -- case 2 means that a word like wrold has been modified to wroldd, and it would correct the
SuggestionSpan of that word from SuggestionSpan(TextRange(n, n+5), <String>["world"]) to SuggestionSpan(TextRange(n, n+6), <String>["world"]), for example. It's this case (and 3 because 3 involves 2) that pushed me to change this method because if you are typing faster than the spell check results update, the red underline flashes under the misspelled word because of the lag (the cursor index/base offset would not be considered as touching the misspelled word you are composing because an "unknown" addition to the word has been made). My changes fix this issue in the case you described. You would still be compoinsg worl --> worlds, but none of it would be underlined in red, unless after composing, it is still misspelled.

Ok I think I got it, we definitely do want the ability to tell that the word is still being edited in these cases so we can hide the red underline.

packages/flutter/lib/src/widgets/spell_check.dart

justinmc · 2023-03-31T20:22:38Z

packages/flutter/lib/src/widgets/spell_check.dart

-  return TextSpan(
+  // We will draw the TextSpan tree based on the composing region, if it is
+  // available.
+  final bool shouldConsiderComposingRegion = defaultTargetPlatform == TargetPlatform.android;


It does have a composing region, it just doesn't use it for the current editing word (as far as I know). Maybe I'm too pessimistic. I thought the Samsung keyboard wasn't compatible at the engine level or something. If it works then that's great.

justinmc · 2023-03-31T20:25:04Z

packages/flutter/lib/src/widgets/spell_check.dart

+
+  return TextSpan(
+    style: style,
+    children: _buildSubtreesWithoutComposingRegion(


That makes me think that we could use only this method and get rid of the other one. It could remove the composing region when it's part of the replaced word and then draw it. Maybe in another PR if that's going to delay this one, though.

justinmc · 2023-03-31T20:35:45Z

packages/flutter/lib/src/widgets/spell_check.dart

-/// Adjusts spell check results to correspond to [newText] if the only results
-/// that the handler has access to are the [results] corresponding to
-/// [resultsText].
-///
-/// Used in the case where the request for the spell check results of the
-/// [newText] is lagging in order to avoid display of incorrect results.


Why did you remove this comment? I think we need something explaining what _correctSpellCheckResults is used for.

This was an accident! Thanks!

justinmc · 2023-03-31T20:53:28Z

packages/flutter/lib/src/widgets/spell_check.dart

+          // Adjust offset to reflect the difference between where currentSpan
+          // was positioned in resultsText versus where the modified version
+          // is positioned in newText.
+          offset = (adjustedSpanEnd - adjustedSpanStart) - (currentSpan.range.end - currentSpan.range.start) + (adjustedSpanStart - currentSpan.range.start);


How are you able to do cases 2 and 3? If I'm understanding correctly, those show that a misspelled word has been modified (wrold to wroldd), and you're still able to correct it (world)? That seems super tricky if I'm understanding it correctly. It might be better to not handle those at all. What if the modification creates a correctly spelled word (worl to worlds)?

justinmc · 2023-03-31T20:59:46Z

packages/flutter/lib/src/widgets/spell_check.dart

-        correctedSpellCheckResults.add(adjustedSpan);
+          correctedSpellCheckResults.add(adjustedSpan);
+          break;
+        }


Any thoughts on the performance of this algorithm? It seems like it repeatedly uses substring in order to reduce the search space (I think substring would be O(1) and therefore a valid optimization) and then indexOf to search, which I would think is O(reduced search space) in the worst case. Probably reasonable given that the misspelled words could have moved anywhere in the string, but let me know if I'm missing anything.

I do believe that's right and I had the same concern. I think some optimizations could be made if we make further assumptions about when this method will be needed, e.g. if we assume only one modification was made, then we'd only need to do one search and then use lookups to verify the rest of the results based on the first (and only, in this case) calculated offset and searchStart. I think it is worth considering, my only concern here is time.

Sounds good, it should be fine as-is for now. We haven't done a lot of work on optimizing for large amounts of text in general in Flutter yet.

Also we probably couldn't ever assume that there was only one modification, even though that's probably the case 99% of the time (because the user pressed a single key on their keyboard). It's possible that the IME has sent us any wild modification or even an entirely new string. We encountered the same problem in @Renzo-Olivares's deltas work.

justinmc · 2023-04-04T18:01:07Z

I tried this out on iOS and overall it looks great, it feels like a huge upgrade to our iOS text input experience. I found three issues, most probably aren't related to this PR. If not then we should probably just create separate issues for them.

While typing a contraction, the spellchecker is briefly enabled after the apostrophe is entered. It seems like we consider an apostrophe to indicate the end of a word when we shouldn't.

Screen.Recording.2023-04-04.at.10.52.18.AM.mov

Entering a semicolon between misspelled words gives two spell check results, one before and one after the semicolon. However, the red underline seems to consider the whole thing to be one word. Notice how when one word is selected, the red underline is removed before and after the semicolon:

Screen.Recording.2023-04-04.at.10.53.12.AM.mov

While the cursor is in contact with a misspelled word, the red underline disappears (correct), however, tapping the word still shows the spell check suggestions. Is that what native does?

Screen.Recording.2023-04-04.at.10.58.05.AM.mov

justinmc · 2023-04-04T18:17:26Z

Alright now I've tested it on the Android emulator too. None of the problems above happen on Android (Gboard).

Type two misspelled words separated by a semicolon. Replace the second word. Sometimes, extra characters will remain after the replacement at the end of the new word.

Screen.Recording.2023-04-04.at.11.10.55.AM.mov

Sometimes, the cursor does not return to the end of the word after tapping a replacement.

Screen.Recording.2023-04-04.at.11.16.02.AM.mov

camsim99 · 2023-04-04T18:40:39Z

@justinmc For iOS:

1/2: These are valid issues because the code relies on spaces a lot. I'll take a look today, but worst case, let's file bugs before this makes it to stable.

3: This is expected! Although, iOS must have done an update, because I now see that for misspelled words, the blue highlight is red. May need to file an issue for this before this reaches stable, as well.

For Android:

1: This is probably an issue on the framework side, too. I echo what I said about filing an issue!

2: I'm not 100% sure I knew it was supposed to do this. I do see it on native, though. It's a simple fix, so I'll also look at that today.

justinmc · 2023-04-04T18:59:31Z

@camsim99 Are you aware that on master spell check suggestions sometimes appear blank on iOS?

No worries because it's fixed in this PR. However, that's a strong reason to make sure this PR gets shipped.

justinmc · 2023-04-04T19:03:25Z

I tried to reproduce all of the numbered bugs I posted above again on master, and they all either can still be reproduced or are blocked by the "blank suggestion" bug I screenshotted. So, this PR does not appear to introduce any new bugs and is an improvement across the board. I agree that we should just file issue for all of the bugs above and move forward with this PR.

No worries about fixing Android bug number 2 here if it's not super simple.

camsim99 · 2023-04-04T19:04:22Z

Are you aware that on master spell check suggestions sometimes appear blank on iOS?

Yes, this is because you are using TextField versus CupertinoTextField :/ With the Cupertino style menu, it will say "no replacement suggestions found" but it doesn't do that in the Material style menu. Thus, this PR won't fix it but we know this is an issue and I will file an issue for that, too.

justinmc · 2023-04-04T21:55:59Z

Oh right, I keep forgetting that. Thanks!

justinmc

Minor nits on the tests, otherwise looks good.

justinmc · 2023-04-04T23:24:02Z

packages/flutter/lib/src/widgets/spell_check.dart

    TextSpan(
      style: composingTextStyle,
-      text: text.substring(composingRegion.start, composingRegion.end)
+      text: text.substring(composingRegion.start, composingRegion.end),


Good find with all the commas!

Learning slowly!! :)

justinmc · 2023-04-04T23:25:03Z

packages/flutter/test/widgets/spell_check_test.dart

-      () {
+  testWidgets(
+  'buildTextSpanWithSpellCheckSuggestions ignores composing region when composing region out of range',
+      (WidgetTester tester) async {


Why make all of these testWidgets instead of test? I think if it doesn't use tester it should just be a test.

I did this to use TargetPlatformVariant

Ah I didn't realize you couldn't use it with test! Sounds good then.

justinmc · 2023-04-04T23:25:50Z

packages/flutter/test/widgets/spell_check_test.dart

-      expect(textSpanTree, equals(expectedTextSpanTree));
-  });
+    expect(textSpanTree, equals(expectedTextSpanTree));
+    }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.iOS }));


Did these tests fail or you just changed them to mobile-only since that's what spell check supports right now?

I mean we can have them run on all, but mobile is what matters so I'd figure I'd change it just to be sure we are testing what we support. Your call! I need them to at least run on those too to try the two different ways of building the TextSpan tree with spell check results.

I say keep it as you have it 👍 . I've seen unnecessary failures happen because a test was running on a platform that it was irrelevant for.

justinmc · 2023-04-04T23:39:13Z

packages/flutter/test/widgets/spell_check_test.dart

    const String text = 'Hello, wrold! Hey';
    const String resultsText = 'Hello, wrold!';
-    const TextEditingValue value = TextEditingValue(
-        text: text, composing: TextRange(start: 14, end: 17));


Is this case with a composing region tested somewhere else? If not, maybe we should keep both, one original with the composing region and one your update without composing region?

Same for other tests where the composing region was removed.

I am open to this, but I don't think it's necessary. Cases with the composing region are tested in the other tests, and the purpose of the tests where I removed it have to do with correcting the spell check results versus correctly styling the composing region.

Ok sounds good to keep it like this if it's covered elsewhere 👍

packages/flutter/test/widgets/spell_check_test.dart

camsim99 · 2023-04-05T15:42:50Z

@justinmc For iOS:

1/2: These are valid issues because the code relies on spaces a lot. I'll take a look today, but worst case, let's file bugs before this makes it to stable.

3: This is expected! Although, iOS must have done an update, because I now see that for misspelled words, the blue highlight is red. May need to file an issue for this before this reaches stable, as well.

For Android:

1: This is probably an issue on the framework side, too. I echo what I said about filing an issue!

2: I'm not 100% sure I knew it was supposed to do this. I do see it on native, though. It's a simple fix, so I'll also look at that today.

Just reverted logic to extend SuggestionSpans when misspelled words have been modified, thanks to @justinmc's suggestion. To update on these issues, based on what I now observe:

For iOS,

1/2: Seems like these are a direct result of the actual spell check results we get back from iOS. Respectively, they do seem to include the semicolon and do not seem to include the apostrophe in the results (at least in that moment while composing the word, e.g "hlelo'" does not have results that include the apostrophe but "hlelo's" does). May have to correct this on the framework end.

3: Native behavior.

For Android,

1: This revert fixes this issue!

2: This is still an issue we will need to address on the framework side.

justinmc

LGTM 👍. Just a few nits.

justinmc · 2023-04-05T16:17:17Z

packages/flutter/lib/src/widgets/spell_check.dart

+      final SuggestionSpan adjustedSpan = SuggestionSpan(
          TextRange(
-              start: currentSpan.range.start + offset, end: searchStart),
-          currentSpan.suggestions
+              start: currentSpan.range.start + offset, end: currentSpan.range.end + offset),
+          currentSpan.suggestions,
      );


Nit: I would format it like this:

final SuggestionSpan adjustedSpan = SuggestionSpan( TextRange( start: currentSpan.range.start + offset, end: currentSpan.range.end + offset, ), currentSpan.suggestions, );

justinmc · 2023-04-05T16:17:59Z

packages/flutter/lib/src/widgets/spell_check.dart

+          TextRange(start: adjustedSpanStart, end: adjustedSpanEnd),
+          currentSpan.suggestions,


Nit: Outdent these two lines.

justinmc · 2023-04-05T16:33:10Z

packages/flutter/test/widgets/spell_check_test.dart

-      () {
+  testWidgets(
+  'buildTextSpanWithSpellCheckSuggestions ignores composing region when composing region out of range',
+      (WidgetTester tester) async {


Ah I didn't realize you couldn't use it with test! Sounds good then.

justinmc · 2023-04-05T16:34:13Z

packages/flutter/test/widgets/spell_check_test.dart

-      expect(textSpanTree, equals(expectedTextSpanTree));
-  });
+    expect(textSpanTree, equals(expectedTextSpanTree));
+    }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.iOS }));


I say keep it as you have it 👍 . I've seen unnecessary failures happen because a test was running on a platform that it was irrelevant for.

justinmc · 2023-04-05T16:34:40Z

packages/flutter/test/widgets/spell_check_test.dart

    const String text = 'Hello, wrold! Hey';
    const String resultsText = 'Hello, wrold!';
-    const TextEditingValue value = TextEditingValue(
-        text: text, composing: TextRange(start: 14, end: 17));


Ok sounds good to keep it like this if it's covered elsewhere 👍

justinmc · 2023-04-05T16:37:27Z

packages/flutter/test/widgets/spell_check_test.dart

    expect(textSpanTree, equals(expectedTextSpanTree));
-  });
+  }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.iOS }));
 }


What happened to the test that you added in 7904ab2?

packages/flutter/test/widgets/spell_check_test.dart

camsim99 · 2023-04-05T21:43:48Z

Frob is having issues and the branch cut is today. Merging to get this in prior.

…composing region (flutter/flutter#123481)

…g region (flutter#123481) Fixes flutter#119534 by adding extra logic to allow the proper `TextSpan` trees to be build with spell check results that does not rely on the composing region. Also, refreshes the algorithm used to correct spell check results to improve cases where spell check results are out of date, but the composing region line does not help smooth over this fact by giving the framework extra time to update while a word is being composed (because a composing region line would cover up any flashing red underlines). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…composing region (flutter/flutter#123481)

camsim99 added 2 commits March 22, 2023 14:38

dev

46d8859

adding progress for push

0aee01b

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 25, 2023

camsim99 added 3 commits March 27, 2023 13:41

Debug

4bde38e

Work on solution

e03fc0d

Updates

fc761eb

justinmc reviewed Mar 29, 2023

View reviewed changes

rewrite

bf1f100

camsim99 closed this Mar 31, 2023

camsim99 reopened this Mar 31, 2023

camsim99 added 2 commits March 31, 2023 11:04

Fix correction algorithm

ee0593d

Review

b97cd66

camsim99 commented Mar 31, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into sc_nocr

9fae1fd

camsim99 marked this pull request as ready for review March 31, 2023 18:46

Fix spaces

22d6186

camsim99 requested a review from justinmc March 31, 2023 19:02

justinmc reviewed Mar 31, 2023

View reviewed changes

camsim99 added 2 commits April 3, 2023 09:05

Fix indention, add back comment

be8f8d7

Merge remote-tracking branch 'upstream/master' into sc_nocr

0bc35fe

camsim99 mentioned this pull request Apr 4, 2023

Merge different strategies for building TextSpans with spell check results #124142

Open

camsim99 added 2 commits April 4, 2023 12:20

Add todo and start fixing tests

2c64df4

Remove ios to get tests passing

5ae3ecb

camsim99 added 3 commits April 4, 2023 15:00

Fix test

7904ab2

Fix analyze

4521d94

Merge remote-tracking branch 'upstream/master' into sc_nocr

86a994b

justinmc reviewed Apr 4, 2023

View reviewed changes

Remove complicated extension logic

4977a57

justinmc approved these changes Apr 5, 2023

View reviewed changes

Address comments

27ab6ab

justinmc reviewed Apr 5, 2023

View reviewed changes

packages/flutter/test/widgets/spell_check_test.dart Outdated Show resolved Hide resolved

update name

16a0163

camsim99 merged commit bc0cbc1 into flutter:master Apr 5, 2023

engine-flutter-autoroll mentioned this pull request Apr 6, 2023

Roll Flutter from daaa32bc0638 to a086c640dcc4 (27 revisions) flutter/packages#3654

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2023

bc0cbc1 Add spell check TextSpan creation logic that doesn't rely on …

98dabdc

…composing region (flutter/flutter#123481)

HansMuller mentioned this pull request Apr 7, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

bc0cbc1 Add spell check TextSpan creation logic that doesn't rely on …

66dbb84

…composing region (flutter/flutter#123481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

bc0cbc1 Add spell check TextSpan creation logic that doesn't rely on …

f71c16b

…composing region (flutter/flutter#123481)

		TextRange(start: adjustedSpanStart, end: adjustedSpanEnd),
		currentSpan.suggestions,

Add spell check TextSpan creation logic that doesn't rely on composing region #123481

Add spell check TextSpan creation logic that doesn't rely on composing region #123481

Uh oh!

Conversation

camsim99 commented Mar 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camsim99 commented Mar 31, 2023

Uh oh!

justinmc commented Mar 31, 2023

Uh oh!

camsim99 commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc commented Mar 31, 2023

Uh oh!

camsim99 commented Mar 31, 2023

Uh oh!

camsim99 Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc commented Apr 4, 2023

Uh oh!

justinmc commented Apr 4, 2023

Uh oh!

camsim99 commented Apr 4, 2023

Uh oh!

justinmc commented Apr 4, 2023

camsim99 commented Mar 25, 2023 •

edited

Loading

camsim99 commented Mar 31, 2023 •

edited

Loading

camsim99 Mar 31, 2023 •

edited

Loading

camsim99 Mar 31, 2023 •

edited

Loading

camsim99 commented Apr 4, 2023 •

edited

Loading