Skip to content

Add smoke test for gstatic resources #123270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harryterkelsen merged 3 commits into from
Mar 24, 2023
Merged

Add smoke test for gstatic resources #123270

harryterkelsen merged 3 commits into from
Mar 24, 2023

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Mar 22, 2023

Adds a test which just checks that the CanvasKit resources can be downloaded from gstatic.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 22, 2023
@harryterkelsen harryterkelsen requested a review from yjbanov March 22, 2023 20:06
yjbanov
yjbanov approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 40bfb70 into flutter:master Mar 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
60b308c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
85c789b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
9c304ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
877862a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
9453ff2
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
b52b4ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
40bfb70 Add smoke test for gstatic resources (flutter/flutter#123270)
e79b2a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @yjbanov