Make custom Utf8Decoder replacement not extend platform class.
#123211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart 3.0 class modifiers will make `Utf8Decoder`, and other pure implementation classes, be `final`. This replacement class does not need to extend the original class, just like the `Utf8Codec` in the same file doesn't extend the `Ut8Codec` from the platform libraries. Instead it can just forward to a single `const` instance of the original class.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
This was referenced Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
8 tasks
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 29, 2023
This is a reland of commit 608934e Can be landed when Flutter with flutter/flutter#123211 has been rolled into internal repository. Original change's description: > Reland "Add class modifiers to `dart:convert`." > > This is a reland of commit b2f4cf3 > > Commented out deprecation for now. > > Original change's description: > > Add class modifiers to `dart:convert`. > > > > The usual approach: > > Pure interfaces marked `interface`. > > Pure implementation classes marked `final`. > > Base classes marked `base` or nothing, and `mixin class` if reasonable. > > Combined X/XBase/XMixin where possible. > > > > CoreLibraryReviewExempt: Aske is away > > Change-Id: I927f9bd488fb385ff9c17c8fc94920a1f5076347 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289200 > > Reviewed-by: Stephen Adams <sra@google.com> > > Reviewed-by: Slava Egorov <vegorov@google.com> > > Reviewed-by: Nate Bosch <nbosch@google.com> > > Commit-Queue: Lasse Nielsen <lrn@google.com> > > CoreLibraryReviewExempt: Approved in original. > Change-Id: I1bc14f99b742567e2634dcfcbc52f332dbcc5364 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290521 > Reviewed-by: Nate Bosch <nbosch@google.com> > Commit-Queue: Lasse Nielsen <lrn@google.com> CoreLibraryReviewExempt: Approved in original. Change-Id: If157e1ef2339d7a06e99a1e402f2f8ac93550b83 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290960 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
This was referenced Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart 3.0 class modifiers will make
Utf8Decoder, and other pure implementation classes, befinal.This replacement class does not need to extend the original class, just like the
Utf8Codecin the same file doesn't extend theUt8Codecfrom the platform libraries.Instead it can just forward to a single
constinstance of the original class.