Skip to content

Use DeviceDiscoveryFilter correctly in ProxiedDevices. #123144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 21, 2023
Merged

Use DeviceDiscoveryFilter correctly in ProxiedDevices. #123144

auto-submit merged 1 commit into from
Mar 21, 2023

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Mar 21, 2023

The device filtering is done on the client side and not the daemon side, so we should pass the device list through the filter if provided.

This fixes the issue introduced in #121359 when ProxiedDevices is used.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@chingjun
Use DeviceDiscoveryFilter correctly in ProxiedDevices.
fc09d32 
The device filtering is done on the client side and not the daemon side,
so we should pass the device list through the filter if provided.
@chingjun chingjun requested a review from vashworth March 21, 2023 19:10
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 21, 2023
vashworth
vashworth approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 7e4822d into flutter:master Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
a7ddba7 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
04632bc 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
bac44e5 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
891ff03 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
51df98a 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
2e1bff5 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
d9e3c04 
…er/flutter#123144)
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
2cb9cfe 
…er/flutter#123144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
d34b4a5 
…er/flutter#123144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
6c87851 
…er/flutter#123144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
65bbd97 
…er/flutter#123144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
7e4822d Use DeviceDiscoveryFilter correctly in ProxiedDevices. (flutt…
c4a03ae 
…er/flutter#123144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingjun @vashworth