Skip to content

[flutter_tools] replace --no-analytics with --suppress-analytics #123133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 21, 2023
Merged

[flutter_tools] replace --no-analytics with --suppress-analytics #123133

auto-submit merged 4 commits into from
Mar 21, 2023

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 21, 2023

Fixes #123118
Fixes #123066

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 21, 2023
andrewkolos
andrewkolos approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Mar 21, 2023

Gonna have to move the flag to after pub, and then update all tests

loic-sharma
loic-sharma approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider running the run output tests using led to verify these don't flake any more.

@loic-sharma loic-sharma mentioned this pull request Mar 21, 2023
Closed
@andrewkolos andrewkolos self-requested a review March 21, 2023 18:17
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Mar 21, 2023

LGTM. Consider running the run output tests using led to verify these don't flake any more.

Those run pre-submit:

Screenshot from 2023-03-21 11-20-19

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 7d76727 into flutter:master Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
9ca6d29 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
8309dbe 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
c2263ca 
…ics (flutter/flutter#123133)
This was referenced Mar 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
09417d9 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
dd69347 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
c3fbccc 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
bc4eb4b 
…ics (flutter/flutter#123133)
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
e07afa9 
…ics (flutter/flutter#123133)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
7638632 
…ics (flutter/flutter#123133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
c6c1f55 
…ics (flutter/flutter#123133)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
2c614ba 
…ics (flutter/flutter#123133)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
7d76727 [flutter_tools] replace --no-analytics with --suppress-analyt…
ab60f31 
…ics (flutter/flutter#123133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter framework tests reporting flakes due to flag name change Migrate to --suppress-analytics flag

3 participants

@christopherfujino @loic-sharma @andrewkolos