Add adaptive Checkbox and CheckboxListTile #123132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuncCccccc
reviewed
Mar 21, 2023
Contributor
QuncCccccc
left a comment
There was a problem hiding this comment.
This looks good to me! Just left two comments about the enum type checking:)
Contributor
There was a problem hiding this comment.
Can we use switch for this check? Just think it would be more consistent with other widgetX.adaptive().
Such as:
switch (_checkboxType) {
case _CheckboxType.material:
break;
case _CheckboxType.adaptive: {
final ThemeData theme = Theme.of(context);
switch (theme.platform) {
case TargetPlatform.android:
case TargetPlatform.fuchsia:
case TargetPlatform.linux:
case TargetPlatform.windows:
break;
case TargetPlatform.iOS:
case TargetPlatform.macOS:
return CupertinoCheckbox(...);
}
}
}
Contributor
There was a problem hiding this comment.
Same here. I think we can do a similar change like the SwitchListTile(code link) so that we don't have to create two objects ahead of time:)
QuncCccccc
approved these changes
Mar 21, 2023
Contributor
There was a problem hiding this comment.
nit: probably don't need this empty line:)
8dc6d8d to
1686989
Compare
6586b7e to
785da77
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2023
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #102810. Adds an adaptive constructor for the Checkbox and CheckboxListTile widgets that displays the checkboxes as either a Material or Cupertino checkbox depending on platform.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.