-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add customizable mouse cursor to DataTable
#123128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @TahaTesser, thanks for working on this! Is it intentional that the checkbox in the header doesn't get any mouse cursor assigned? Personally, given that checkbox mouse cursors are themeable, I'd be fine with not assigning a mouse cursor to data row checkboxes either just to keep it consistent. |
a86c5dc to
bc18eb0
Compare
That makes sense. Just updated the PR to not update the checkboxes cursor and include a test that verifies it. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #123020
Description
mouseCursorto theDataColumnfor the header cell.mouseCursorMaterialStateProperty to theDataRowfor the data rowheadingCellCursorto customize the cursor in the header cell fromDataTableTheme.dataRowCursorto customize the cursor in the data row fromDataTableTheme.code sample
Screen.Recording.2023-03-22.at.16.16.59.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.