Skip to content

Adding timestamps to task runner output lines. #123075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 21, 2023
Merged

Adding timestamps to task runner output lines. #123075

auto-submit merged 1 commit into from
Mar 21, 2023

Conversation

@yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented Mar 21, 2023

Now we prefix stdout/err lines with datetime stamp as:

[2023-03-20 17:11:03.653128] [STDOUT] Enabling configs for macOS and Linux...

Bug:#119750

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 21, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 21, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

keyonghan
keyonghan previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But you need to get a test exempt from Ian in hackers- discord chanel.

@keyonghan keyonghan self-requested a review March 21, 2023 17:01
@keyonghan keyonghan dismissed their stale review March 21, 2023 17:02

Based on #123075 (comment), I can LGTM after you get the test exempt.

@yusuf-goog yusuf-goog self-assigned this Mar 21, 2023
@yusuf-goog yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 21, 2023

auto label is removed for flutter/flutter, pr: 123075, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 21, 2023

auto label is removed for flutter/flutter, pr: 123075, due to Validations Fail.

@yusuf-goog yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
yjbanov
yjbanov approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yusuf-goog
Adding timestamps to task runner output lines.
6e3c73f 
Now we prefix stdout/err lines with datetime stamp as:

[2023-03-20 17:11:03.653128] [STDOUT] Enabling configs for macOS and Linux...

Bug:flutter#119750
@Hixie
Copy link
Contributor

Hixie commented Mar 21, 2023

test-exempt: is for tests

might be worth making the output a little less verbose, microseconds may be a little excessive (the date might be too much too.)

@auto-submit auto-submit bot merged commit 47dd992 into flutter:master Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
fc35d25 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
8cde352 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
4aa8f0a 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
9748465 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
98346c9 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
883b49e 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
c6bb768 
…er#123075)
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
cb7c834 
…er#123075)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
e63fe57 
…er#123075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
3530c98 
…er#123075)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
d3e33c4 
…er#123075)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
47dd992 Adding timestamps to task runner output lines. (flutter/flutt…
cb43350 
…er#123075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@jmagman jmagman Awaiting requested review from jmagman

@keyonghan keyonghan Awaiting requested review from keyonghan

+1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yusuf-goog yusuf-goog

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yusuf-goog @Hixie @yjbanov @godofredoc @keyonghan