Skip to content

CP: Use packages/packages recipe. (#122822) #122842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 4 commits into from
Mar 16, 2023
Merged

CP: Use packages/packages recipe. (#122822) #122842

godofredoc merged 4 commits into from
Mar 16, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 16, 2023 •
edited
Loading

CP: 9f35ed7

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use packages/packages recipe. (#122822)
a9b57df 
Use packages/packages recipe.
@godofredoc godofredoc requested a review from keyonghan as a code owner March 16, 2023 22:47
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 16, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc godofredoc changed the title Use packages/packages recipe. (#122822) CP: Use packages/packages recipe. (#122822) Mar 16, 2023
XilaiZhang
XilaiZhang approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)
just for my learning purposes, why are we downgrading from v2?

@godofredoc
Copy link
Contributor Author

godofredoc commented Mar 16, 2023

images (1) just for my learning purposes, why are we downgrading from v2?

This is a cleanup. Packages_v2/packages_v2 was copied to packages/packages to deprecate the v2 transitional paths.

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Mar 16, 2023

This is a cleanup. Packages_v2/packages_v2 was copied to packages/packages to deprecate the v2 transitional paths.

Thanks for explaining! and congratulations on landing packages v2!

@godofredoc
Copy link
Contributor Author

godofredoc commented Mar 16, 2023

This is a cleanup. Packages_v2/packages_v2 was copied to packages/packages to deprecate the v2 transitional paths.

Thanks for explaining! and congratulations on landing packages v2!

The credit should go to @sealesj who implemented most parts, I'm only doing the cleanup.

@godofredoc godofredoc merged commit d477bcc into flutter:flutter-3.7-candidate.1 Mar 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
d477bcc CP: Use packages/packages recipe. (#122822) (flutter/flutter#…
6bca993 
…122842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
d477bcc CP: Use packages/packages recipe. (#122822) (flutter/flutter#…
97a8e1b 
…122842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
d477bcc CP: Use packages/packages recipe. (#122822) (flutter/flutter#…
4082bb1 
…122842)
@godofredoc godofredoc deleted the flutter-3.7-candidate.1 branch May 24, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

+1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @XilaiZhang @fluttergithubbot