Deprecates `TestWindow` #122824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

auto-submit merged 1 commit into flutter:master from pdblasi-google:issues/121915

Mar 21, 2023

Contributor

pdblasi-google commented Mar 16, 2023 •

edited

Loading

Deprecates TestWindow

Adds Deprecated annotations to TestWindow and its constructors.
Adds Deprecated annotations to all properties and methods on TestWindow except noSuchMethod.
Adds Deprecated annotation to TestWidgetsFlutterBinding.window.
Adds flutter_test specific deprecation documentation to TestWidgetsFlutterBinding.window.

Resolves #121915.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

pdblasi-google requested review from goderbauer and loic-sharma

March 16, 2023 19:36

flutter-dashboard bot added a: tests framework labels

flutter-dashboard bot commented Mar 16, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer mentioned this pull request

Migrate away from deprecated TestWindow API flutter/cocoon#2539

Merged

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

loic-sharma reviewed

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

loic-sharma approved these changes

View reviewed changes

Member

loic-sharma left a comment

This looks good to me but please also get an approval from someone who has more experience with our deprecation process :)

goderbauer reviewed

View reviewed changes

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

pdblasi-google force-pushed the issues/121915 branch 3 times, most recently from 3f714b0 to eeb05ed Compare

March 17, 2023 18:22

pdblasi-google mentioned this pull request

Update tests to ignore deprecated_member_use where TestWindow API is used flutter/packages#3485

Merged

11 tasks

goderbauer mentioned this pull request

☂️ Deprecate window singleton #116929

Closed

33 tasks

goderbauer approved these changes

View reviewed changes

Member

goderbauer left a comment

LGTM! 🚀

Member

goderbauer commented Mar 21, 2023

Looks like the upstream fixes to the packages repo rolled in with #123117. Rebasing this PR should hopefully turn the "Linux flutter_plugins" check green. I believe we are ready to submit this one then?


          Deprecates TestWindow

b6da817

* Adds `Deprecated` annotations to `TestWindow` and its constructors.
* Adds `Deprecated` annotations to all properties and methods on `TestWindow` except `noSuchMethod`.
* Adds `Deprecated` annotation to `TestWidgetsFlutterBinding.window`.
* Adds `flutter_test` specific deprecation documentation to `TestWidgetsFlutterBinding.window`.

pdblasi-google force-pushed the issues/121915 branch from eeb05ed to b6da817 Compare

March 21, 2023 16:28

pdblasi-google added the autosubmit label

auto-submit bot merged commit 4695fcc into flutter:master

pdblasi-google deleted the issues/121915 branch

March 21, 2023 20:18

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 520cf363b355 (27 revisions) flutter/packages#3514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

44594f3

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 02599119f2bf (29 revisions) flutter/packages#3516

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

2c5b3a3

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 3f87e808f86b (30 revisions) flutter/packages#3517

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

0d42bea

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to b42e8db6cf8f (31 revisions) flutter/packages#3519

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

888badd

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 98a305501028 (33 revisions) flutter/packages#3520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

8640eb8

engine-flutter-autoroll mentioned this pull request

Manual roll Flutter from 1ba3f99bb0aa to f68a676353ed (37 revisions) flutter/packages#3522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

21c5847

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 250a6c294264 (46 revisions) flutter/packages#3528

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

8f40bfa

This was referenced Mar 23, 2023

Manual roll Flutter from 1ba3f99bb0aa to 250a6c294264 (46 revisions) flutter/packages#3529

Merged

Roll Flutter from 1ba3f99bb0aa to 250a6c294264 (46 revisions) flutter/packages#3530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

09c1051

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

4f7b00f

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 1ba3f99bb0aa to 897e3db40cb9 (48 revisions) flutter/packages#3531

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

8b09698

HansMuller mentioned this pull request

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

3ac3318

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4695fcc Deprecates TestWindow (flutter/flutter#122824)

c66a449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests autosubmit framework