Skip to content

Conversation

@flar
Copy link
Contributor

@flar flar commented Mar 10, 2023

This test seems to suddenly be timing out when we try to roll an Engine that has a new Dart SDK with a minimum sdk version of 2.12.

@flar flar requested a review from a-siva March 10, 2023 20:33
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 10, 2023
@flar flar requested a review from christopherfujino March 10, 2023 20:42
name: foo_project
environment:
sdk: '>=2.10.0 <4.0.0'
sdk: '>=2.12.0 <4.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just verifying there are no other hard-coded constraints we need to bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve and tag for autosubmit if you find that this is a sufficiently complete fix.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2023

auto label is removed for flutter/flutter, pr: 122423, due to - The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@flar flar merged commit 3b65899 into flutter:master Mar 10, 2023
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants