Skip to content

Bug report 2 issue template #122385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 12 commits into from
Apr 12, 2023
Merged

Bug report 2 issue template #122385

auto-submit merged 12 commits into from
Apr 12, 2023

Conversation

@exaby73
Copy link
Member

@exaby73 exaby73 commented Mar 10, 2023 •
edited
Loading

This PR migrates the bug report template to Github Forms

Fixes #119918

Preview of new form

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 10, 2023
@exaby73 exaby73 changed the title Draft: Bug report 2 issue template Bug report 2 issue template Mar 10, 2023
@exaby73 exaby73 marked this pull request as ready for review March 10, 2023 11:26
@exaby73 exaby73 changed the title Bug report 2 issue template Draft: Bug report 2 issue template Mar 10, 2023
@exaby73 exaby73 marked this pull request as draft March 10, 2023 18:01
@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from a247861 to df41039 Compare March 13, 2023 04:37
@darshankawar
Copy link
Member

darshankawar commented Mar 13, 2023

  1. The template description can be improved as below:

You found a bug in the application. It is crashing or throws an exception, a widget is buggy or something looks wrong.

Screenshot 2023-03-13 at 6 24 00 PM

  1. The first line seems repetitive, so we can remove it and just keep If our documentation doesn't have an answer.. statement.

  2. Code sample field should be mandatory I think.

@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from df41039 to 47f0718 Compare March 14, 2023 07:51
@darshankawar
Copy link
Member

darshankawar commented Mar 14, 2023 •
edited
Loading

Screenshot 2023-03-14 at 6 47 36 PM

2. The first line seems repetitive, so we can remove it and just keep If our documentation doesn't have an answer.. statement.

This line If you have found a bug is repetitive with description of the template, or we can simply remove this line altogether.

@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from 885bfb5 to 9d34283 Compare March 15, 2023 07:24
@exaby73
Copy link
Member Author

exaby73 commented Mar 15, 2023

Fixed it :)

@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from 0b6dfad to df90317 Compare March 15, 2023 10:40
@darshankawar
Copy link
Member

darshankawar commented Mar 15, 2023

LGTM.

helinanever
helinanever reviewed Mar 15, 2023
View reviewed changes
@exaby73 exaby73 marked this pull request as ready for review March 15, 2023 14:25
@exaby73 exaby73 changed the title Draft: Bug report 2 issue template Bug report 2 issue template Mar 15, 2023
@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch 2 times, most recently from 92b780c to c5c88fb Compare March 24, 2023 08:36
@stuartmorgan-g stuartmorgan-g self-requested a review March 24, 2023 11:46
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. and removed a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Mar 28, 2023
stuartmorgan-g
stuartmorgan-g approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits, I'm sorry for the long delay on this :(

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 11, 2023
@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from de60fe7 to 24afc22 Compare April 11, 2023 11:48
@exaby73
Copy link
Member Author

exaby73 commented Apr 11, 2023

Fix the nits and rebased

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 11, 2023

auto label is removed for flutter/flutter, pr: 122385, due to - The status or check suite Linux firebase_abstract_method_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@exaby73 exaby73 force-pushed the bug-report-2-issue-template branch from 24afc22 to fb221c8 Compare April 12, 2023 08:52
@exaby73
Copy link
Member Author

exaby73 commented Apr 12, 2023

Rebased, now all checks pass. @Piinks maybe autosubmit can be added again?

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 12, 2023

FYI, you should be able to add the label yourself.

@auto-submit auto-submit bot merged commit 6d01ae1 into flutter:master Apr 12, 2023
@exaby73
Copy link
Member Author

exaby73 commented Apr 12, 2023

Yes just not sure if that's allowed and if that's considered merging my own PR :) But thanks

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 12, 2023

Absolutely! Once you have approval on a PR, you're welcome to autosubmit it as soon as you're ready :)

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
6d01ae1 Bug report 2 issue template (flutter/flutter#122385)
b210255
exaby73 added a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@exaby73
Bug report 2 issue template (flutter#122385)
f7c622a 
Bug report 2 issue template
@TahaTesser TahaTesser deleted the bug-report-2-issue-template branch May 3, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helinanever helinanever helinanever left review comments

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate the "Bug report" issue template to Github forms

6 participants

@exaby73 @darshankawar @stuartmorgan-g @helinanever @goderbauer @Piinks