Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller redux." #122362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We should also be able to see any regressions/improvements if we look through the benchmarks |
zanderso
approved these changes
Mar 10, 2023
Member
|
I filed a few issues for things I saw in SkiaPerf |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
…eller redux. (flutter#122340)" (flutter#122362) Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller redux."
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… use Impeller redux. (#122340)" (flutter/flutter#122362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122340
everything seems good, reverting!