Skip to content

fix devtool instructional messages after flutter build ... --analyze-size . Fixes #122229 #122230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 9, 2023
Merged

fix devtool instructional messages after flutter build ... --analyze-size . Fixes #122229 #122230

auto-submit merged 3 commits into from
Mar 9, 2023

Conversation

@timmaffett
Copy link
Contributor

@timmaffett timmaffett commented Mar 8, 2023

This PR fixes the instructional messages regarding running devtools after using the flutter build ... --analyze-size command.

This fixes #122229.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 8, 2023
christopherfujino
christopherfujino approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eliasyishak
eliasyishak approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eliasyishak eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 2e8c346 into flutter:master Mar 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
0f2feca 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
902bfcc 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
369eee4 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@timmaffett @hannah-hyj
fix devtool instructional messages after `flutter build ... --analyze…
044e022 
…-size `. Fixes flutter#122229 (flutter#122230)

fix devtool instructional messages after `flutter build ... --analyze-size `.  Fixes flutter#122229
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
2225f3a 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
d5b605b 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
2fad561 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2e8c346 fix devtool instructional messages after `flutter build ... -…
e2c0265 
…-analyze-size `. Fixes #122229 (flutter/flutter#122230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@eliasyishak eliasyishak eliasyishak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter] Instructional messages regarding running devtools to analyze app size are outdated and incorrect

3 participants

@timmaffett @christopherfujino @eliasyishak