Fix allowedButtonsFilter not working as intended when null.
#122227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daed5ab to
976dbb0
Compare
976dbb0 to
9c2f170
Compare
9c2f170 to
bcce4bb
Compare
allowedButtonsFilter not being passed when null.
allowedButtonsFilter not being passed when null.allowedButtonsFilter not working as intended when null.
Renzo-Olivares
approved these changes
Mar 8, 2023
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM thanks for fixing that!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unaware
ImmediateMultiDragGestureRecognizer()!=ImmediateMultiDragGestureRecognizer(allowedButtonsFilter : null). This fixes that. Thanks @stuartmorgan for the help. Without you this wouldn't be possible.This should have the "side effect" of making
Draggableonly work with primary click. This wasn't happening becauseDraggableapplied anullallowedButtonsFilter and thenGestureRecognizerjust returned "true". Now it should work as intended on #111852 (but that never worked, unfortunately).cc @Renzo-Olivares.
cc @moffatman.