[Impeller] Temporary flag flip for devicelab tests to use Impeller. #122224
Conversation
|
First commit updates most devicelab config to use a single constants, second commit changes the constant value. To be reverted after a few commits to see failures/performance changes This should have no impact outside of the devicelab and does not impact developers or google3 rolls. |
zanderso
left a comment
There was a problem hiding this comment.
These are the tests where I think we already have Impeller variants running. Are there any others that are easy to put under a toggle like this?
|
I don't think we have impeller variants for all of them - but this is probably the best we can do. There are one or two tests that build and run via XCode so i could add an FLTEnableImpeller true there. Besides that, its mostly build tests and tool tests which won't really be impacted either way |
|
I updated this so we add --enable-impeller to anything that goes through the flutterArgs command targeting iOS. |
| final String? localEngineSrcPath = localEngineSrcPathFromEnv; | ||
| return <String>[ | ||
| command, | ||
| if (!command.contains('--enable-impeller') |
There was a problem hiding this comment.
Should this also be controlled by kEnableImpellerDefault?
There was a problem hiding this comment.
I think that was an optimistic idea and instead I'll end up reverting the whole thing anyway, so it probably doesn't matter
|
In retrospect this would have been a better spot: flutter/dev/devicelab/lib/framework/utils.dart Lines 457 to 460 in 4adb299 Check if --enable-impeller isn't present, and if the command is run or drive, then add it.
|
…lutter#122224) [Impeller] Temporary flag flip for devicelab tests to use Impeller.
…eller. (flutter#122224)" (flutter#122236) This reverts commit 21b8b72.
To make #122223 easier, replace all these values with a constant, then change the constant to true.