Skip to content

Add one DefaultTextStyle example #122182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 8, 2023
Merged

Add one DefaultTextStyle example #122182

auto-submit merged 1 commit into from
Mar 8, 2023

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Mar 8, 2023

Description

This PR adds an example to DefaultTextStyle to put more emphasis on DefaultTextStyle.merge.

Related Issue

Fixes #122180

Tests

Adds 1 test for the new example.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 8, 2023
@bleroux bleroux mentioned this pull request Mar 8, 2023
Closed
Piinks
Piinks approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. Nice, thank you!

examples/api/lib/widgets/text/text.0.dart Outdated
Copy link
Contributor

@Piinks Piinks Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste leftovers?

Copy link
Contributor Author

@bleroux bleroux Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

@bleroux bleroux force-pushed the add_one_DefaultTextStyle_example branch from 0edd9a9 to b1c1edd Compare March 8, 2023 19:26
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit auto-submit bot merged commit 3b4a882 into flutter:master Mar 8, 2023
@bleroux bleroux deleted the add_one_DefaultTextStyle_example branch March 8, 2023 20:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
7218416
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
8dbb4fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
63b2ed8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
584a049
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@bleroux @hannah-hyj
Add one DefaultTextStyle example (flutter#122182)
5a42bdb 
Add one DefaultTextStyle example
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
58f59b6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
72a7de1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
0c02b52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3b4a882 Add one DefaultTextStyle example (flutter/flutter#122182)
de76529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DefaultTextStyle.merge should be emphasized

2 participants

@bleroux @Piinks