Funnel devicelab tests through utils process methods #122161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Mar 8, 2023
|
|
||
| TaskFunction createHotModeTest({ | ||
| String? deviceIdOverride, | ||
| Map<String, String>? environment, |
Member
Author
There was a problem hiding this comment.
environment wasn't passed in anywhere, remove it.
jmagman
commented
Mar 8, 2023
| appDartSource.writeAsStringSync( | ||
| appDartSource.readAsStringSync().replaceFirst( | ||
| "'Flutter Gallery'", "'Updated Flutter Gallery'", | ||
| smallReloadData = await captureReloadData( |
Member
Author
There was a problem hiding this comment.
This part is mostly whitespace changes.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
Funnel devicelab tests through utils process methods
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devicelab tests are failing with "lost connection", and it would be helpful to add screenshots when these commands fail (instead of adding a tricky-to-pipe
flutter run --screenshotoption, do it in the test harness).Refactor devicelab tests to use the utils
startFlutteretc. process methods so in my next PR I can add a hook for screenshots.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.