Skip to content

SelectionChangedCause for iOS keyboard-select #122144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 10, 2023
Merged

SelectionChangedCause for iOS keyboard-select #122144

auto-submit merged 1 commit into from
Mar 10, 2023
+42 −5

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Mar 7, 2023

By setting the proper selection change cause here instead of SelectionChangedCause.keyboard, the selection-handles will be displayed when using floating-keyboard-selection. I used SelectionChangedCause.forcePress as it is the closest one. It was also already used for floating-keyboard-cursor.

Part of #30476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2023
@moffatman moffatman mentioned this pull request Mar 7, 2023
Merged
8 tasks
@moffatman moffatman force-pushed the keyboard_select_cause branch from 5cad081 to 8d153b8 Compare March 7, 2023 23:35
@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot merged commit e078c93 into flutter:master Mar 10, 2023
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@moffatman @hannah-hyj
SelectionChangedCause for iOS keyboard-select (flutter#122144)
f7dae62 
SelectionChangedCause for iOS keyboard-select
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
e078c93 SelectionChangedCause for iOS keyboard-select (flutter/flutte…
b23eb96 
…r#122144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
e078c93 SelectionChangedCause for iOS keyboard-select (flutter/flutte…
4dfa123 
…r#122144)
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e078c93 SelectionChangedCause for iOS keyboard-select (flutter/flutte…
40835e8 
…r#122144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e078c93 SelectionChangedCause for iOS keyboard-select (flutter/flutte…
a85466f 
…r#122144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moffatman @LongCatIsLooong