Create configOnly flag for android #121904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like you have compilation errors in your test |
Contributor
Author
Thank you, For my own notes I was able to find and fix these by useing. |
| final File gradleFile = fileSystem | ||
| .directory(exampleAppDir) | ||
| .childDirectory('android') | ||
| .childFile('gradlew'); |
Contributor
There was a problem hiding this comment.
will this be gradlew.bat on windows?
Contributor
Author
There was a problem hiding this comment.
yes it will. I didnt realize this was something our testing relied on but I have updated the test.
| ], workingDirectory: exampleAppDir.path); | ||
|
|
||
| expect(gradleFile, exists); | ||
| expect(result.stdout, contains(RegExp(r'Config complete'))); |
Contributor
There was a problem hiding this comment.
could you also assert some file that an actual assemble would have generated does NOT exist?
Contributor
Author
There was a problem hiding this comment.
I can assert that the assembling log does not show which I think accomplishes the same goal while being a bit easier to implement.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
Create configOnly flag for android
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93407
Inspired by the work the iOS team has done to create a similar flag.
Additionally this is pre work for helping the flutter/packages work move towards more offline CI.