Skip to content

Remove newline #121090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
esouthren merged 4 commits into from
Feb 23, 2023
Merged

Remove newline #121090

esouthren merged 4 commits into from
Feb 23, 2023

Conversation

@esouthren
Copy link
Contributor

@esouthren esouthren commented Feb 20, 2023 •
edited
Loading

Fixes a newline erroneously introduced by me in #120976.

@esouthren esouthren added the f: material design flutter/packages/flutter/material repository. label Feb 20, 2023
@esouthren esouthren self-assigned this Feb 20, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 20, 2023
@esouthren esouthren requested a review from guidezpl February 20, 2023 12:37
@esouthren esouthren marked this pull request as ready for review February 20, 2023 12:37
@navaronbracke
Copy link
Contributor

navaronbracke commented Feb 20, 2023 •
edited
Loading

@esouthren Could you also add

  @override
  OutlinedBorder get shape => const RoundedRectangleBorder(
    borderRadius: BorderRadius.all(Radius.circular(2.0)),
  );

in the M3 Checkbox defaults? You'll have to alter the template a little:

// gen_defaults/checkbox_template.dart

  @override
  OutlinedBorder get shape => const RoundedRectangleBorder(
    borderRadius: BorderRadius.all(Radius.circular(${tokens['md.comp.checkbox.unselected.outline.width']})),
  );

@esouthren
Copy link
Contributor Author

esouthren commented Feb 20, 2023

Thanks @navaronbracke - added.

@esouthren esouthren merged commit 0c1ed75 into flutter:master Feb 23, 2023
@esouthren esouthren deleted the newline branch February 23, 2023 10:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
ed34735
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
830a9b0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
e4dfa3c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
6deafe1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
521e15f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
9165f97
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
27b3320
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
df6104f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
8e74cad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
d82c84e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
fba9650
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
dbd871f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
74cff9e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
52c3125
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
fdd7392
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
d7d5d51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
f929004
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
b1d90b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
d3a46db
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
259d925
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
87235a8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
486bd93
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0c1ed75 Remove newline (flutter/flutter#121090)
0be7bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

@esouthren esouthren

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esouthren @navaronbracke @guidezpl