Skip to content

Added negative test and blur test to the wide gamut tests. #120914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Feb 22, 2023
Merged

Added negative test and blur test to the wide gamut tests. #120914

auto-submit merged 5 commits into from
Feb 22, 2023

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 16, 2023

These tests were added in response to feedback from Dan and Brandon in code reviews.

issue: #117182

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 16, 2023
@gaaclarke gaaclarke marked this pull request as draft February 16, 2023 23:21
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 16, 2023

Putting this back as a draft. It isn't quite right. The blur test should incorporate transparency to correctly capture what we want.

@gaaclarke gaaclarke marked this pull request as ready for review February 16, 2023 23:50
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 16, 2023

Okay I fixed it by adding a transparent donut to the test image.

@gaaclarke gaaclarke mentioned this pull request Feb 17, 2023
Merged
8 tasks
@gaaclarke gaaclarke force-pushed the expand-wide-gamut-tests branch from b3e0360 to e0abb9f Compare February 21, 2023 22:36
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 21, 2023

rebasing to hopefully chase away unrelated ci failures

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit 4c25587 into flutter:master Feb 22, 2023
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4c25587b7 Added negative test and blur test to the wide gamut tests. (f…
c7da1d8 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
6446a07 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
a3314d7 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
c07611b 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
2133948 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
bb5fe35 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
741de9f 
…lutter/flutter#120914)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
ef332c5 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
11ee6f2 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
1114842 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
a2b6122 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
4fbed87 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
c856a53 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
c576101 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
4b84fff 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
d8bad50 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
f0ae73c 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
fcd2847 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
e7cfd1f 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
e857c59 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
8b89a48 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
88cfe05 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
be2f712 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
e18404c 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
f1c9ad7 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
2f447c0 
…lutter/flutter#120914)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4c25587 Added negative test and blur test to the wide gamut tests. (f…
4af7ffc 
…lutter/flutter#120914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bdero bdero

@dnfield dnfield

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @dnfield @bdero