Skip to content

Added backgroundColor and disabledBackgroundColor to SnackBarAction. #118786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 1 commit into from
Mar 27, 2023
Merged

Added backgroundColor and disabledBackgroundColor to SnackBarAction. #118786

HansMuller merged 1 commit into from
Mar 27, 2023

Conversation

@chinmoy12c
Copy link
Member

@chinmoy12c chinmoy12c commented Jan 19, 2023

This PR adds backgroundColor and disabledBackgroundColor properties to SnackBarAction.

Fixes: #109933

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2023
@chinmoy12c chinmoy12c mentioned this pull request Jan 19, 2023
Closed
8 tasks
@HansMuller HansMuller self-requested a review January 20, 2023 20:05
@chinmoy12c
Copy link
Member Author

chinmoy12c commented Feb 18, 2023

@HansMuller could you please review this?

@HansMuller HansMuller requested a review from esouthren February 21, 2023 17:18
esouthren
esouthren suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@esouthren esouthren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chinmoy12c, thanks for your patience on the review.

Mostly LGTM; some small comments.

@chinmoy12c
Copy link
Member Author

chinmoy12c commented Mar 18, 2023

Hey @esouthren sorry for the delay, made the changes :)

@chinmoy12c chinmoy12c requested review from esouthren and removed request for HansMuller March 27, 2023 07:19
esouthren
esouthren approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@esouthren esouthren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit aa5db20 into flutter:master Mar 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
713c3ec 
…Action. (flutter/flutter#118786)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
9dd91e1 
…Action. (flutter/flutter#118786)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
15104e8 
…Action. (flutter/flutter#118786)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
a2bc9ee 
…Action. (flutter/flutter#118786)
@reidbaker reidbaker mentioned this pull request Mar 28, 2023
Merged
8 tasks
@HansMuller HansMuller mentioned this pull request Mar 31, 2023
Closed
This was referenced Apr 1, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
099eb7d 
…Action. (flutter/flutter#118786)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
aa5db20 Added backgroundColor and disabledBackgroundColor to SnackBar…
b5ddf8f 
…Action. (flutter/flutter#118786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@HansMuller HansMuller HansMuller approved these changes

@esouthren esouthren esouthren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to set background color of SnackBarAction when clicked

3 participants

@chinmoy12c @HansMuller @esouthren