Improve `TextPainter.layout` caching #118128

LongCatIsLooong · 2023-01-07T00:53:56Z

Improves TextPainter.layout caching when only the input constraints change:

removes the double layout calls in TextPainter._layoutParagraph: now double layout is only needed when TextAlign is not left, and the input maxWidth == double.infinity.
skip calls to ui.Paragraph.layout when it's guaranteed that there's no soft line breaks before/after the layout call.

This doesn't introduce new APIs but may slightly shift text rendered on screen.
This reduces the number of layout calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible.

528 scuba failures but all of them seem reasonable.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ature

Hixie · 2023-01-10T00:02:57Z

packages/flutter/lib/src/painting/text_painter.dart

we really should stop doing this

also the comment is just wrong (it's been wrong for a long time). we looked at doing what it says, but we decided not to, many years ago. if we're going to make a breaking change anyway, we might as well remove this at the same time...

based on the conversation in #31707, it doesn't seem to be safe to remove this hack yet, since widths/maxIntrinsicWidths are reported in floats and the input widths are doubles

After removing the rounding in the framework and skparagraph, and tuning down the harfbuzz scale from 1^16 to 1^10, with this change there are only 50 framework failures and nothing seems to be overflowing. So I guess that's doable but I'd like to try to do that in a separate PR.

@Hixie still this breaks 500+ scuba tests. But I'm not sure how I can write a migration guide for this one.

Hixie · 2023-01-10T00:05:08Z

packages/flutter/lib/src/painting/text_painter.dart

(nit: extraneous spaces after //)

Hixie · 2023-01-10T00:05:53Z

packages/flutter/lib/src/painting/text_painter.dart

not sure what this comment means

removed. I thought if the text doesn't contain hard breaks the extra width will be distributed among the whitespaces in that line, but turns out the end of line is counted as a hard break so when maxWidth > maxIntrinsicWidth it's the same as TextAlign.start.

Hixie · 2023-01-10T00:06:14Z

packages/flutter/lib/src/painting/text_painter.dart

for clarity it might be good to say 0.0 and 1.0 instead of 0 and 1 when they're doubles

Hixie · 2023-01-10T00:07:03Z

packages/flutter/lib/src/painting/text_painter.dart

this might be clearer?

Suggested change

final List<TextBox> rawBoxes = layout._inlinePlaceholderBoxes

??= layout.paragraph.getBoxesForPlaceholders();

layout._inlinePlaceholderBoxes ??= layout.paragraph.getBoxesForPlaceholders();

final List<TextBox> rawBoxes = layout._inlinePlaceholderBoxes;

_inlinePlaceholderBoxes's type is List<TextBox>? so I would have to use !.

Roll Flutter from 216605b to ee162e4 (53 revisions) flutter/flutter@216605b...ee162e4 2023-05-26 engine-flutter-autoroll@skia.org Roll Packages from 995bfc5 to 9f8dcc5 (4 revisions) (flutter/flutter#127671) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) (flutter/flutter#127647) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) (flutter/flutter#127644) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) (flutter/flutter#127642) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) (flutter/flutter#127641) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) (flutter/flutter#127638) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) (flutter/flutter#127635) 2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) (flutter/flutter#127633) 2023-05-26 31859944+LongCatIsLooong@users.noreply.github.com Remove a bad assert from tooltip implementation (flutter/flutter#127629) 2023-05-26 31859944+LongCatIsLooong@users.noreply.github.com Remove rounding from TextPainter (flutter/flutter#127099) 2023-05-26 109253501+pdblasi-google@users.noreply.github.com Adds `TestDisplay` API for testing `Display` features (flutter/flutter#127525) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) (flutter/flutter#127630) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) (flutter/flutter#127625) 2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/flutter#127537) 2023-05-25 chillers@google.com Indent markdown value on CP issue template (flutter/flutter#127623) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (flutter/flutter#127619) 2023-05-25 42216813+eliasyishak@users.noreply.github.com `ProcessResultMatcher` created and used in test (flutter/flutter#127414) 2023-05-25 chillers@google.com Fix yaml lint issue (flutter/flutter#127600) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (flutter/flutter#127609) 2023-05-25 36861262+QuncCccccc@users.noreply.github.com `SearchBar` should not be impacted by overall `InputDecorationTheme` (flutter/flutter#127465) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (flutter/flutter#127601) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (flutter/flutter#127591) 2023-05-25 dnfield@google.com avoid incorrect usage of TimelineTask (flutter/flutter#127527) 2023-05-25 tessertaha@gmail.com Add `ScrollNotificationObserver` sample (flutter/flutter#127023) 2023-05-25 engine-flutter-autoroll@skia.org Roll Packages from fba97fa to 995bfc5 (3 revisions) (flutter/flutter#127590) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (flutter/flutter#127577) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (flutter/flutter#127565) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (flutter/flutter#127563) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (flutter/flutter#127560) 2023-05-25 31859944+LongCatIsLooong@users.noreply.github.com Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (flutter/flutter#119199) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (flutter/flutter#127554) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (flutter/flutter#127551) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (flutter/flutter#127546) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (flutter/flutter#127544) 2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (flutter/flutter#127542) 2023-05-24 chillers@google.com Revert "Update labeler action wildcards" (flutter/flutter#127541) 2023-05-24 mdebbar@google.com [web] ui.platformViewRegistry => ui_web.platformViewRegistry (flutter/flutter#127493) 2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (flutter/flutter#127536) 2023-05-24 lsaudon@gmail.com Add missing parameters in `TextFormField` (flutter/flutter#127020) 2023-05-24 chillers@google.com Update labeler action wildcards (flutter/flutter#127524) 2023-05-24 31859944+LongCatIsLooong@users.noreply.github.com Improve `TextPainter.layout` caching (flutter/flutter#118128) 2023-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533) 2023-05-24 leroux_bruno@yahoo.fr Fix ScrollPosition overscroll precision error (flutter/flutter#127321) 2023-05-24 dleyba042@gmail.com `Slider.onChangeStart` & `Slider.onChangeEnd` are not called on keyboard shortcuts (flutter/flutter#126896) 2023-05-24 bdero@google.com Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (flutter/flutter#127514) 2023-05-24 chillers@google.com Update CP template to include timeline and changelog (flutter/flutter#127507) ...

LongCatIsLooong added 14 commits December 21, 2022 00:39

Avoid affinity like the plague

c90738c

ignore lint

1523dca

clean up

d9a1b16

fix test

1aad3e1

review

4bf8749

Merge remote-tracking branch 'upstream/master' into TextBoundary-sign…

a49e27f

…ature

Move wordboundary to text painter

1ada762

docs

978e4d3

fix tests

c8d733b

wip

d344b2a

Merge remote-tracking branch 'upstream/master' into text-layout

c452e0f

fix tests

6d0cee7

test

f6cb305

remove stuff

8531a11

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 7, 2023

LongCatIsLooong closed this Jan 7, 2023

LongCatIsLooong added 2 commits January 9, 2023 13:42

fix tests

d789f53

add tests

0f7f05b

LongCatIsLooong changed the title ~~Less ui.Paragraph.layout calls.~~ Reduce ui.Paragraph.layout calls, make it less destructive Jan 9, 2023

LongCatIsLooong reopened this Jan 9, 2023

LongCatIsLooong changed the title ~~Reduce ui.Paragraph.layout calls, make it less destructive~~ Improve ui.Paragraph.layout caching Jan 9, 2023

LongCatIsLooong changed the title ~~Improve ui.Paragraph.layout caching~~ Improve TextPainter.layout caching Jan 9, 2023

docs

ceac8ea

Hixie reviewed Jan 10, 2023

View reviewed changes

LongCatIsLooong deleted the text-layout branch May 25, 2023 04:15

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to 20e164e60cb2 (27 revisions) flutter/packages#4077

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

10e989f

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to 60a64a5a5c7f (28 revisions) flutter/packages#4078

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

8efa73d

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to 3e610f7333f6 (29 revisions) flutter/packages#4079

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

4d5f4cc

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to c05a05e6fcc0 (30 revisions) flutter/packages#4080

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

44e7fd5

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to a21f33e7ad2f (31 revisions) flutter/packages#4081

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

f874fe4

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to e583ba4cf0b1 (32 revisions) flutter/packages#4082

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

4d6b909

engine-flutter-autoroll mentioned this pull request May 25, 2023

Roll Flutter from 216605b60f67 to f71075db2eba (33 revisions) flutter/packages#4083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

8013a63

engine-flutter-autoroll mentioned this pull request May 25, 2023

Manual roll Flutter from 216605b60f67 to 08266bdfcf11 (38 revisions) flutter/packages#4084

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

201260b

reidbaker mentioned this pull request May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request May 26, 2023

Roll Flutter from 216605b60f67 to 369192ae5049 (52 revisions) flutter/packages#4088

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

2361e07

engine-flutter-autoroll mentioned this pull request May 26, 2023

Roll Flutter from 216605b60f67 to ee162e4b7f4f (53 revisions) flutter/packages#4090

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

9061dc6

reidbaker mentioned this pull request May 26, 2023

i127682 android api 33 test support #127689

Merged

8 tasks

HansMuller mentioned this pull request May 26, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

b08d00a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

752e4bd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

62312bc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

62e78bf Improve TextPainter.layout caching (flutter/flutter#118128)

2367295

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve `TextPainter.layout` caching #118128

Improve `TextPainter.layout` caching #118128

Uh oh!

LongCatIsLooong commented Jan 7, 2023 •

edited

Loading

Uh oh!

Hixie Jan 10, 2023

Uh oh!

Hixie Jan 10, 2023

Uh oh!

LongCatIsLooong Jan 23, 2023

Uh oh!

LongCatIsLooong Feb 2, 2023

Uh oh!

LongCatIsLooong Feb 2, 2023

Uh oh!

Hixie Jan 10, 2023

Uh oh!

Hixie Jan 10, 2023

Uh oh!

LongCatIsLooong Jan 10, 2023

Uh oh!

Hixie Jan 10, 2023

Uh oh!

Hixie Jan 10, 2023

Uh oh!

LongCatIsLooong Jan 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-    final List<TextBox> rawBoxes = layout._inlinePlaceholderBoxes
-                               ??= layout.paragraph.getBoxesForPlaceholders();
+    layout._inlinePlaceholderBoxes ??= layout.paragraph.getBoxesForPlaceholders();
+    final List<TextBox> rawBoxes = layout._inlinePlaceholderBoxes;

Improve TextPainter.layout caching #118128

Improve TextPainter.layout caching #118128

Uh oh!

Conversation

LongCatIsLooong commented Jan 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Improve `TextPainter.layout` caching #118128

Improve `TextPainter.layout` caching #118128

LongCatIsLooong commented Jan 7, 2023 •

edited

Loading