Revert "Add support for double tap and drag for text selection #109573" #117497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#109573)" This reverts commit cd0f15a.
This was referenced Dec 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Dec 22, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 22, 2022
* d1244b7 da77d1a3a Roll Skia from 2e3ee507e838 to 7ad6f27aff57 (1 revision) (flutter/engine#38447) (flutter/flutter#117474) * 400b05a Manual package roll (flutter/flutter#117439) * 9a347fb Support safe area and scrolling in the NavigationDrawer (flutter/flutter#116995) * 2a50236 Add native unit tests to iOS and macOS templates (flutter/flutter#117147) * 1970bc9 cacheWidth cacheHeight support for canvaskit on web (flutter/flutter#117423) * ff347bf Fix `InkRipple` doesn't respect `rectCallback` when rendering ink circle (flutter/flutter#117395) * ddb7e43 Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (flutter/flutter#117489) * 8ff1b6e Fix Scaffold bottomSheet null exceptions (flutter/flutter#117008) * 2931e50 Handle the case of no selection rects (flutter/flutter#117419) * 39fa011 Revert "Add support for double tap and drag for text selection (#109573)" (flutter/flutter#117497) * b8b3567 Remove single-view assumption from widgets library (flutter/flutter#117480) * ca7ca3b Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (flutter/flutter#117499) * 9fb1ae8 [iOS] Add task for spell check integration test (flutter/flutter#116222)
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Dec 22, 2022
* 9aa2ea1 Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (flutter/flutter#117109) * 409a39d remove debugPrint from timePicker test (flutter/flutter#117111) * 169b49f Revert "[framework] make transform with filterQuality a rpb (#116792)" (flutter/flutter#117095) * 47300e0 Roll Plugins from 10c0293 to 78de28c (4 revisions) (flutter/flutter#117145) * dcd2170 Fix typos in scale gesture recognizer docs (flutter/flutter#117116) * fc3571e Improve documentation of `compute()` function (flutter/flutter#116878) * b122200 Roll Flutter Engine from db5605ea7115 to 29196519c124 (13 revisions) (flutter/flutter#117148) * f1d157b Add an integration test to plugin template example (flutter/flutter#117062) * ada4460 Audit `covariant` usage in tool (flutter/flutter#116930) * 1eaf5c0 [flutter_tools] tree shake icons from web builds (flutter/flutter#115886) * 91c1c70 Bump ossf/scorecard-action from 2.0.6 to 2.1.0 (flutter/flutter#117170) * c98978a Update Navigator updatePages() (flutter/flutter#116945) * 0916375 [tools]Build IPA validation UI Polish (flutter/flutter#116744) * a41c447 Pass dimension explicitly to mac x64 packaging. (flutter/flutter#117172) * 86b62a3 Tiny fix about outdated message (flutter/flutter#114391) * a34e419 Inject current `FlutterView` into tree and make available via `View.of(context)` (flutter/flutter#116924) * c7cb5f3 [flutter_tools] pin package intl and roll pub packages (flutter/flutter#117168) * 7336312 Do not filter the stderr output of "flutter run" in the devicelab run tests (flutter/flutter#117188) * fa711f7 Run packaging on presubtmit. (flutter/flutter#116943) * 76bb8ea Reland "Fix text field label animation duration and curve" (#114646)" * 80e1008 fix: #110342 unable to update rich text widget gesture recognizer (flutter/flutter#116849) * da7b832 Bottom App Bar M3 background color fix (flutter/flutter#117082) * ab47fc3 Roll Plugins from 78de28c to cbcf507 (3 revisions) (flutter/flutter#117213) * 23a2fa3 Reland "Adds API in semanticsconfiguration to decide how to merge chi… (flutter/flutter#116895) * 9102f2f Revert "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117214) * 3d0607b Defer `systemFontsDidChange` to the transientCallbacks phase (flutter/flutter#117123) * ecf9b2d Update localization of shortcut labels in menus (flutter/flutter#116681) * 0604a0e Add a recursive flag to the zip command - currently it is zipping nothing (flutter/flutter#117227) * 98e9032 [web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (flutter/flutter#117217) * ebeb491 Use the name of errors, not the diagnostic messages. (flutter/flutter#117229) * 93c581a Formatted and removed lints from devicelab README.md (flutter/flutter#117239) * 5018a6c Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (flutter/flutter#117242) * 36d536a Roll Flutter Engine from d91e20879a67 to 60cf34e2abf1 (4 revisions) (flutter/flutter#117246) * c9dd458 42689eafb Sped up FlutterStandardCodec writing speed. (flutter/engine#38345) (flutter/flutter#117249) * 0a2a1d9 d45d375ae [iOS, macOS] Migrate from assert to FML_DCHECK (flutter/engine#38368) (flutter/flutter#117256) * bf5fdb9 Reland "Inject current FlutterView into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117244) * 427b2fb 901b455d0 Roll Fuchsia Mac SDK from bn5VF1-xDf-wKjIw8... to qYE6uXjRtAxy7p5HB... (flutter/engine#38373) (flutter/flutter#117258) * cee3e6c b10769998 Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation. (flutter/engine#38365) (flutter/flutter#117260) * 7b850ef f74dd5331 Roll Fuchsia Linux SDK from H6B0UgW07fc1nBtnc... to PqyqxdbUFyd8xoYIP... (flutter/engine#38377) (flutter/flutter#117262) * b20a9e0 imporve gesture recognizer semantics test cases (flutter/flutter#117257) * a82c556 3626c487a Add a missing include to display_list_matrix_clip_tracker.h (flutter/engine#38371) (flutter/flutter#117269) * 9daf2a6 Roll Flutter Engine from 3626c487a610 to 7e296985f426 (2 revisions) (flutter/flutter#117270) * d0d13c5 51b84d69b Roll Fuchsia Mac SDK from qYE6uXjRtAxy7p5HB... to qk9nUlw83EeMMaWmE... (flutter/engine#38380) (flutter/flutter#117273) * 725049f 794370b9c Roll Fuchsia Linux SDK from PqyqxdbUFyd8xoYIP... to bloqad357AGI6lnOb... (flutter/engine#38381) (flutter/flutter#117276) * 49f3ca4 eeae936f9 Use canvaskit `toByteData` for unsupported videoFrame formats (flutter/engine#38361) (flutter/flutter#117279) * c0dddac Fix is canvas kit bool (flutter/flutter#116944) * d88d524 276327f7e Roll Fuchsia Mac SDK from qk9nUlw83EeMMaWmE... to DdU--deE0Xl4TQ2Bm... (flutter/engine#38383) (flutter/flutter#117286) * b7d9be0 747a9d8c7 Roll Skia from 7b0a9d9a3008 to 0362c030efa7 (9 revisions) (flutter/engine#38385) (flutter/flutter#117289) * 1233fc9 37387019b Roll Fuchsia Linux SDK from bloqad357AGI6lnOb... to mRBUNknZk43y-LHGS... (flutter/engine#38386) (flutter/flutter#117290) * a3a0048 3c6cab032 Roll Fuchsia Mac SDK from DdU--deE0Xl4TQ2Bm... to NLb_T58g0l_X46JEN... (flutter/engine#38387) (flutter/flutter#117295) * 420c6d6 Roll Flutter Engine from 3c6cab03274f to 58ab5277a7c4 (2 revisions) (flutter/flutter#117312) * d238bed Roll Plugins from cbcf507 to 840a049 (8 revisions) (flutter/flutter#117314) * 3eefb7a a9491515f Roll Skia from 0362c030efa7 to fc0ac31a46f8 (4 revisions) (flutter/engine#38399) (flutter/flutter#117317) * 9f9010f [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (flutter/flutter#116892) * 32da250 a12dadfda Roll Fuchsia Mac SDK from NLb_T58g0l_X46JEN... to NS4fVXM2KhKcZ1uyD... (flutter/engine#38400) (flutter/flutter#117319) * cb988c7 Add `indicatorColor` & `indicatorShape` to `NavigationRail`, `NavigationDrawer` and move these properties from destination to `NavigationBar` (flutter/flutter#117049) * 5fcb48d Fix `NavigationRail` highlight (flutter/flutter#117320) * 70f391d 7bc519375 Roll Skia from fc0ac31a46f8 to 46af4ad25426 (1 revision) (flutter/engine#38403) (flutter/flutter#117322) * 9f2c5d8 Support `flutter build web --wasm` (flutter/flutter#117075) * 55584ad Roll Flutter Engine from 7bc519375b7b to 45713ea10510 (2 revisions) (flutter/flutter#117330) * 4daff08 Roll Flutter Engine from 45713ea10510 to cba3a3990138 (5 revisions) (flutter/flutter#117336) * 1adc275 Bump min SDK to 2.19.0-0 (flutter/flutter#117345) * efadc34 Roll Flutter Engine from cba3a3990138 to 6de29d1cba70 (3 revisions) (flutter/flutter#117354) * b30947b roll packages (flutter/flutter#117226) * e625e5f 3330cce60 Roll Fuchsia Linux SDK from yGQvkNl85l1TSeuo9... to uKNwsaf92uZcX_QiY... (flutter/engine#38411) (flutter/flutter#117358) * 50a23d9 339791f19 Roll Skia from 8876daf17554 to e8c3fa6d7d2f (3 revisions) (flutter/engine#38413) (flutter/flutter#117366) * 7f7a877 Implemented Scrim Focus for BottomSheet (flutter/flutter#116743) * 38e3930 Exposed tooltip longPress action when available (flutter/flutter#117338) * 61fb6ea Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (flutter/flutter#117372) * c64dcbe Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (flutter/flutter#117396) * 8289ea6 Move a comment where it belongs (flutter/flutter#117385) * fa3777b Enable `sized_box_shrink_expand` lint (flutter/flutter#117371) * e0742eb [Android] Add spell check suggestions toolbar (flutter/flutter#114460) * 0220afd enable use_enums (flutter/flutter#117376) * d71fa88 Bump ossf/scorecard-action from 2.1.0 to 2.1.1 (flutter/flutter#117337) * 4591f05 roll packages (flutter/flutter#117357) * 46bb853 Revert "Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)" (flutter/flutter#117402) * 81bc54b Enable `use_colored_box` lint (flutter/flutter#117370) * fdd2d7d Sync analysis_options.yaml & cleanups (flutter/flutter#117327) * de35764 [Android] Bump template AGP and NDK versions (flutter/flutter#116536) * b308555 Enable `dangling_library_doc_comments` and `library_annotations` lints (flutter/flutter#117365) * b3c7fe3 enable test_ownership in presubmit (flutter/flutter#117414) * 014b8f7 Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (flutter/flutter#117421) * cd0f15a Add support for double tap and drag for text selection (flutter/flutter#109573) * e8e26b6 c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (flutter/flutter#117425) * a3e7fe3 de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (flutter/flutter#117429) * 1699351 4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (flutter/flutter#117433) * 9024c95 28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (flutter/flutter#117435) * cae7846 c9ee05b68 use min/max sandwich test on unit test bounds (flutter/engine#38435) (flutter/flutter#117442) * 6819f72 Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (flutter/flutter#117443) * f5c0716 4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (flutter/flutter#117454) * a7a5d14 Roll Plugins from 840a049 to 54fc206 (6 revisions) (flutter/flutter#117456) * 51a3e3a 1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision) (flutter/engine#38445) (flutter/flutter#117459) * d1244b7 da77d1a3a Roll Skia from 2e3ee507e838 to 7ad6f27aff57 (1 revision) (flutter/engine#38447) (flutter/flutter#117474) * 400b05a Manual package roll (flutter/flutter#117439) * 9a347fb Support safe area and scrolling in the NavigationDrawer (flutter/flutter#116995) * 2a50236 Add native unit tests to iOS and macOS templates (flutter/flutter#117147) * 1970bc9 cacheWidth cacheHeight support for canvaskit on web (flutter/flutter#117423) * ff347bf Fix `InkRipple` doesn't respect `rectCallback` when rendering ink circle (flutter/flutter#117395) * ddb7e43 Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (flutter/flutter#117489) * 8ff1b6e Fix Scaffold bottomSheet null exceptions (flutter/flutter#117008) * 2931e50 Handle the case of no selection rects (flutter/flutter#117419) * 39fa011 Revert "Add support for double tap and drag for text selection (#109573)" (flutter/flutter#117497) * b8b3567 Remove single-view assumption from widgets library (flutter/flutter#117480) * ca7ca3b Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (flutter/flutter#117499) * 9fb1ae8 [iOS] Add task for spell check integration test (flutter/flutter#116222)
Renzo-Olivares
pushed a commit
to Renzo-Olivares/flutter
that referenced
this pull request
Jan 3, 2023
flutter#109573)" (flutter#117497)" This reverts commit 39fa011.
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
… (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com>
loic-sharma
pushed a commit
to fluttergithubbot/flutter
that referenced
this pull request
Jan 6, 2023
…er#109573)" (flutter#117497) This reverts commit cd0f15a. Co-authored-by: Renzo Olivares <roliv@google.com>
loic-sharma
pushed a commit
to fluttergithubbot/flutter
that referenced
this pull request
Jan 6, 2023
…r#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com>
esouthren
pushed a commit
to esouthren/flutter
that referenced
this pull request
Jan 15, 2023
…r#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com>
esouthren
pushed a commit
to esouthren/flutter
that referenced
this pull request
Jan 16, 2023
…r#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com>
esouthren
pushed a commit
that referenced
this pull request
Jan 16, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (#117783) * 3460f34 [fuchsia] Set presentation interval (flutter/engine#38549) (#117785) * Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788) * 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (#117790) * Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795) * e012dc8 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (#117799) * 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (#117800) * e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (#117802) * af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (#117804) * 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (#117805) * d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (#117824) * Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830) * 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966 [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (#117832) * Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (#117834) * 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (#117840) * 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (#117846) * Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (#117856) * 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (#117858) * 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (#117863) * e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (#117865) * 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (#117868) * 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (#117874) * Updated to tokens v0.150. (#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (#117923) * 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a7 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e8 [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (#117503)" (#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (#117661) * fix typos (#117592) * c0b3f8f Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (#117931) * Add convenience constructors for SliverList (#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80 [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (#117935) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c4685 Roll quiver to 3.2.1 (flutter/engine#38617) (#117942) * Send text direction in selection rects (#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (#117940) * roll packages (#118001) * [Android] Increase timeout duration for spell check integration test (#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c4685 to cdd3bf2 (8 revisions) (#118014) * 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dc Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440cc fix roll (flutter/engine#38635) * 87bdde8 Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf2 make DisplayListFlags constexpr throughout (flutter/engine#38649) * 6051576 [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (#118016) * 35b7dee [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (#118017) * b9b0193 Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (#118018) * a01548f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (#118039) * bb40152 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (#118042) * Avoid using `TextAffinity` in `TextBoundary` (#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (#118048) * 5bd90d6 Consider more roles as text (flutter/engine#38645) (#118049) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a Remove single view assumptions from `window.dart` (flutter/engine#38453) (#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (#118183) * Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (#118125) * c582547 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b4 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (#117716) * Roll Flutter Engine from 03609b4 to b5513d7 (2 revisions) (#118186) * fd5a96e Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7 to 5bdb04f (2 revisions) (#118187) * e208090 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (#118189) * Update to Xcode 14.2 (#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (#115337) * Roll Flutter Engine from 51baed6 to 5df0072 (3 revisions) (#118192) * 1812863 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (#118130) * eb5c6f0 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (#118197) * Update `ListTile` to support Material 3 (#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add #99933 HTML workaround. * 3a7d886 Re-enable UIA text/range provider unit tests (flutter/engine#38718) (#118201) * Fix path for require.js (#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d2 Roll flutter/packages to 25454e (flutter/engine#38685) (#118205) * Roll Flutter Engine from ee0c4d2 to 264aa03 (2 revisions) (#118208) * 5a39a88 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa03 Revert "Add CI builder for windows-arm64. (#38394)" (flutter/engine#38729) * 9c0b187 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (#118210) * add closed/open focus traversal; use open on web (#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187 to 716bb91 (3 revisions) (#118220) * b6720a5 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb91 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (#118026) * Allow select cases to be numbers (#116625) * [Impeller Scene] Add SceneC asset importing (#118157) * Add a comment about repeat event + fix typos (#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (#116894) * Roll Flutter Engine from 716bb91 to 687e3cb (2 revisions) (#118242) * 24ee5c1 Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (#117990) * remove unsound mode web test (#118256) * Update `CupertinoPicker` example (#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (#118117) * Add option for opting out of enter route snapshotting. (#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (#118272) * Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (#118274) * ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (#118287) * Fix Finnish TimeOfDate format (#118204) * init * add test * Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (#118289) * b9a7234 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c removed forbidden skia include (flutter/engine#38761) (#118296) * 8d7beac Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (#118297) * 6256f05 Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f91 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab7 Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (#118335) * Roll Flutter Engine from ee76ab7 to cccaae2 (3 revisions) (#118349) * 5ec03d7 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead94 delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e0 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (#118355) * Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (#118357) * 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d686 Add CI builder for windows-arm64. (#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (#111570) * Marks Mac channels_integration_test to be unflaky (#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (#118322) * docs: update docs about color property in material card (#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (#118185) * [M3] Add error state support for side property of CheckBox (#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (#118216) * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (#118359) * Roll Flutter Engine from 4a8d686 to c01465a (9 revisions) (#118409) * 2d2c5e7 Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954 fix canvas drawLine bugs (flutter/engine#38753) * 2b024cb [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea1 Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f5 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c0 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e9 Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa79 Revert "fix canvas drawLine bugs (#38753)" (flutter/engine#38815) * c01465a Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 6880157 fixed glfw example for arm64 (flutter/engine#38426) (#118413) * Use correct API docs link in create --sample help message (#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 6880157 to 35cfe91 (2 revisions) (#118415) * e9b7a2d [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe91 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26ba Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (#118420) * add generated_plugins.cmake (#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: #118324 Bug: #118327 Bug: #118328 * 99509a7 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (#118425) * Roll Flutter Engine from 99509a7 to f3f0536 (2 revisions) (#118429) * 091c785 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f0536 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * a62d253 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (#118435) * dfa0327 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (#118436) * 07603c6 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (#118439) * Fix copying/applying font fallback with package (#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec6089 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (#118445) * 970889b Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (#118448) * a512ceb Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (#116940) * Marks Mac_ios spell_check_test to be unflaky (#117743) * [Linux] Add a 'flutter run' console output test (#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (#116778) * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (#117940) * roll packages (#118001) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (#118157) * roll packages (#118117) * roll packages (#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
esouthren
pushed a commit
that referenced
this pull request
Jan 18, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (#117783) * 3460f34 [fuchsia] Set presentation interval (flutter/engine#38549) (#117785) * Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788) * 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (#117790) * Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795) * e012dc8 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (#117799) * 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (#117800) * e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (#117802) * af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (#117804) * 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (#117805) * d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (#117824) * Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830) * 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966 [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (#117832) * Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (#117834) * 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (#117840) * 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (#117846) * Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (#117856) * 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (#117858) * 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (#117863) * e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (#117865) * 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (#117868) * 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (#117874) * Updated to tokens v0.150. (#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (#117923) * 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a7 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e8 [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (#117503)" (#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (#117661) * fix typos (#117592) * c0b3f8f Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (#117931) * Add convenience constructors for SliverList (#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80 [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (#117935) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c4685 Roll quiver to 3.2.1 (flutter/engine#38617) (#117942) * Send text direction in selection rects (#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (#117940) * roll packages (#118001) * [Android] Increase timeout duration for spell check integration test (#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c4685 to cdd3bf2 (8 revisions) (#118014) * 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dc Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440cc fix roll (flutter/engine#38635) * 87bdde8 Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf2 make DisplayListFlags constexpr throughout (flutter/engine#38649) * 6051576 [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (#118016) * 35b7dee [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (#118017) * b9b0193 Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (#118018) * a01548f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (#118039) * bb40152 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (#118042) * Avoid using `TextAffinity` in `TextBoundary` (#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (#118048) * 5bd90d6 Consider more roles as text (flutter/engine#38645) (#118049) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a Remove single view assumptions from `window.dart` (flutter/engine#38453) (#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (#118183) * Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (#118125) * c582547 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b4 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (#117716) * Roll Flutter Engine from 03609b4 to b5513d7 (2 revisions) (#118186) * fd5a96e Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7 to 5bdb04f (2 revisions) (#118187) * e208090 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (#118189) * Update to Xcode 14.2 (#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (#115337) * Roll Flutter Engine from 51baed6 to 5df0072 (3 revisions) (#118192) * 1812863 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (#118130) * eb5c6f0 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (#118197) * Update `ListTile` to support Material 3 (#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add #99933 HTML workaround. * 3a7d886 Re-enable UIA text/range provider unit tests (flutter/engine#38718) (#118201) * Fix path for require.js (#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d2 Roll flutter/packages to 25454e (flutter/engine#38685) (#118205) * Roll Flutter Engine from ee0c4d2 to 264aa03 (2 revisions) (#118208) * 5a39a88 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa03 Revert "Add CI builder for windows-arm64. (#38394)" (flutter/engine#38729) * 9c0b187 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (#118210) * add closed/open focus traversal; use open on web (#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187 to 716bb91 (3 revisions) (#118220) * b6720a5 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb91 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (#118026) * Allow select cases to be numbers (#116625) * [Impeller Scene] Add SceneC asset importing (#118157) * Add a comment about repeat event + fix typos (#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (#116894) * Roll Flutter Engine from 716bb91 to 687e3cb (2 revisions) (#118242) * 24ee5c1 Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (#117990) * remove unsound mode web test (#118256) * Update `CupertinoPicker` example (#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (#118117) * Add option for opting out of enter route snapshotting. (#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (#118272) * Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (#118274) * ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (#118287) * Fix Finnish TimeOfDate format (#118204) * init * add test * Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (#118289) * b9a7234 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c removed forbidden skia include (flutter/engine#38761) (#118296) * 8d7beac Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (#118297) * 6256f05 Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f91 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab7 Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (#118335) * Roll Flutter Engine from ee76ab7 to cccaae2 (3 revisions) (#118349) * 5ec03d7 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead94 delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e0 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (#118355) * Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (#118357) * 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d686 Add CI builder for windows-arm64. (#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (#111570) * Marks Mac channels_integration_test to be unflaky (#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (#118322) * docs: update docs about color property in material card (#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (#118185) * [M3] Add error state support for side property of CheckBox (#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (#118216) * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (#118359) * Roll Flutter Engine from 4a8d686 to c01465a (9 revisions) (#118409) * 2d2c5e7 Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954 fix canvas drawLine bugs (flutter/engine#38753) * 2b024cb [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea1 Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f5 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c0 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e9 Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa79 Revert "fix canvas drawLine bugs (#38753)" (flutter/engine#38815) * c01465a Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 6880157 fixed glfw example for arm64 (flutter/engine#38426) (#118413) * Use correct API docs link in create --sample help message (#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 6880157 to 35cfe91 (2 revisions) (#118415) * e9b7a2d [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe91 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26ba Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (#118420) * add generated_plugins.cmake (#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: #118324 Bug: #118327 Bug: #118328 * 99509a7 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (#118425) * Roll Flutter Engine from 99509a7 to f3f0536 (2 revisions) (#118429) * 091c785 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f0536 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * a62d253 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (#118435) * dfa0327 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (#118436) * 07603c6 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (#118439) * Fix copying/applying font fallback with package (#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec6089 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (#118445) * 970889b Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (#118448) * a512ceb Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (#116940) * Marks Mac_ios spell_check_test to be unflaky (#117743) * [Linux] Add a 'flutter run' console output test (#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (#116778) * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (#117940) * roll packages (#118001) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (#118157) * roll packages (#118117) * roll packages (#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…er#109573)" (flutter#117497) This reverts commit cd0f15a. Co-authored-by: Renzo Olivares <roliv@google.com>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…r#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f34 [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (flutter#117788) * 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (flutter#117795) * e012dc8 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (flutter#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (flutter#117830) * 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966 [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (flutter#117834) * 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (flutter#117856) * 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (flutter#117923) * 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a7 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e8 [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8f Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80 [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c4685 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c4685 to cdd3bf2 (8 revisions) (flutter#118014) * 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dc Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440cc fix roll (flutter/engine#38635) * 87bdde8 Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf2 make DisplayListFlags constexpr throughout (flutter/engine#38649) * 6051576 [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193 Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb40152 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (flutter#118125) * c582547 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b4 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b4 to b5513d7 (2 revisions) (flutter#118186) * fd5a96e Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7 to 5bdb04f (2 revisions) (flutter#118187) * e208090 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6 to 5df0072 (3 revisions) (flutter#118192) * 1812863 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d886 Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d2 Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d2 to 264aa03 (2 revisions) (flutter#118208) * 5a39a88 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa03 Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187 to 716bb91 (3 revisions) (flutter#118220) * b6720a5 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb91 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb91 to 687e3cb (2 revisions) (flutter#118242) * 24ee5c1 Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (flutter#118274) * ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (flutter#118289) * b9a7234 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05 Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f91 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab7 Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab7 to cccaae2 (3 revisions) (flutter#118349) * 5ec03d7 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead94 delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e0 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (flutter#118357) * 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d686 Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d686 to c01465a (9 revisions) (flutter#118409) * 2d2c5e7 Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954 fix canvas drawLine bugs (flutter/engine#38753) * 2b024cb [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea1 Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f5 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c0 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e9 Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa79 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 6880157 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 6880157 to 35cfe91 (2 revisions) (flutter#118415) * e9b7a2d [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe91 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26ba Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7 to f3f0536 (2 revisions) (flutter#118429) * 091c785 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f0536 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d253 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec6089 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512ceb Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (flutter#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f34 [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (flutter#117788) * 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (flutter#117795) * e012dc8 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (flutter#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (flutter#117830) * 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966 [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (flutter#117834) * 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (flutter#117856) * 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (flutter#117923) * 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a7 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e8 [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8f Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80 [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c4685 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c4685 to cdd3bf2 (8 revisions) (flutter#118014) * 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dc Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440cc fix roll (flutter/engine#38635) * 87bdde8 Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf2 make DisplayListFlags constexpr throughout (flutter/engine#38649) * 6051576 [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193 Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb40152 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (flutter#118125) * c582547 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b4 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b4 to b5513d7 (2 revisions) (flutter#118186) * fd5a96e Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7 to 5bdb04f (2 revisions) (flutter#118187) * e208090 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6 to 5df0072 (3 revisions) (flutter#118192) * 1812863 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d886 Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d2 Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d2 to 264aa03 (2 revisions) (flutter#118208) * 5a39a88 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa03 Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187 to 716bb91 (3 revisions) (flutter#118220) * b6720a5 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb91 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb91 to 687e3cb (2 revisions) (flutter#118242) * 24ee5c1 Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (flutter#118274) * ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (flutter#118289) * b9a7234 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05 Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f91 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab7 Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab7 to cccaae2 (3 revisions) (flutter#118349) * 5ec03d7 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead94 delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e0 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (flutter#118357) * 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d686 Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d686 to c01465a (9 revisions) (flutter#118409) * 2d2c5e7 Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954 fix canvas drawLine bugs (flutter/engine#38753) * 2b024cb [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea1 Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f5 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c0 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e9 Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa79 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 6880157 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 6880157 to 35cfe91 (2 revisions) (flutter#118415) * e9b7a2d [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe91 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26ba Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7 to f3f0536 (2 revisions) (flutter#118429) * 091c785 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f0536 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d253 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec6089 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512ceb Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (flutter#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 9aa2ea1 Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (flutter/flutter#117109) * 409a39d remove debugPrint from timePicker test (flutter/flutter#117111) * 169b49f Revert "[framework] make transform with filterQuality a rpb (#116792)" (flutter/flutter#117095) * 47300e0 Roll Plugins from 10c0293 to 78de28c (4 revisions) (flutter/flutter#117145) * dcd2170 Fix typos in scale gesture recognizer docs (flutter/flutter#117116) * fc3571e Improve documentation of `compute()` function (flutter/flutter#116878) * b122200 Roll Flutter Engine from db5605ea7115 to 29196519c124 (13 revisions) (flutter/flutter#117148) * f1d157b Add an integration test to plugin template example (flutter/flutter#117062) * ada4460 Audit `covariant` usage in tool (flutter/flutter#116930) * 1eaf5c0 [flutter_tools] tree shake icons from web builds (flutter/flutter#115886) * 91c1c70 Bump ossf/scorecard-action from 2.0.6 to 2.1.0 (flutter/flutter#117170) * c98978a Update Navigator updatePages() (flutter/flutter#116945) * 0916375 [tools]Build IPA validation UI Polish (flutter/flutter#116744) * a41c447 Pass dimension explicitly to mac x64 packaging. (flutter/flutter#117172) * 86b62a3 Tiny fix about outdated message (flutter/flutter#114391) * a34e419 Inject current `FlutterView` into tree and make available via `View.of(context)` (flutter/flutter#116924) * c7cb5f3 [flutter_tools] pin package intl and roll pub packages (flutter/flutter#117168) * 7336312 Do not filter the stderr output of "flutter run" in the devicelab run tests (flutter/flutter#117188) * fa711f7 Run packaging on presubtmit. (flutter/flutter#116943) * 76bb8ea Reland "Fix text field label animation duration and curve" (#114646)" * 80e1008 fix: #110342 unable to update rich text widget gesture recognizer (flutter/flutter#116849) * da7b832 Bottom App Bar M3 background color fix (flutter/flutter#117082) * ab47fc3 Roll Plugins from 78de28c to cbcf507 (3 revisions) (flutter/flutter#117213) * 23a2fa3 Reland "Adds API in semanticsconfiguration to decide how to merge chi… (flutter/flutter#116895) * 9102f2f Revert "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117214) * 3d0607b Defer `systemFontsDidChange` to the transientCallbacks phase (flutter/flutter#117123) * ecf9b2d Update localization of shortcut labels in menus (flutter/flutter#116681) * 0604a0e Add a recursive flag to the zip command - currently it is zipping nothing (flutter/flutter#117227) * 98e9032 [web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (flutter/flutter#117217) * ebeb491 Use the name of errors, not the diagnostic messages. (flutter/flutter#117229) * 93c581a Formatted and removed lints from devicelab README.md (flutter/flutter#117239) * 5018a6c Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (flutter/flutter#117242) * 36d536a Roll Flutter Engine from d91e20879a67 to 60cf34e2abf1 (4 revisions) (flutter/flutter#117246) * c9dd458 42689eafb Sped up FlutterStandardCodec writing speed. (flutter/engine#38345) (flutter/flutter#117249) * 0a2a1d9 d45d375ae [iOS, macOS] Migrate from assert to FML_DCHECK (flutter/engine#38368) (flutter/flutter#117256) * bf5fdb9 Reland "Inject current FlutterView into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117244) * 427b2fb 901b455d0 Roll Fuchsia Mac SDK from bn5VF1-xDf-wKjIw8... to qYE6uXjRtAxy7p5HB... (flutter/engine#38373) (flutter/flutter#117258) * cee3e6c b10769998 Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation. (flutter/engine#38365) (flutter/flutter#117260) * 7b850ef f74dd5331 Roll Fuchsia Linux SDK from H6B0UgW07fc1nBtnc... to PqyqxdbUFyd8xoYIP... (flutter/engine#38377) (flutter/flutter#117262) * b20a9e0 imporve gesture recognizer semantics test cases (flutter/flutter#117257) * a82c556 3626c487a Add a missing include to display_list_matrix_clip_tracker.h (flutter/engine#38371) (flutter/flutter#117269) * 9daf2a6 Roll Flutter Engine from 3626c487a610 to 7e296985f426 (2 revisions) (flutter/flutter#117270) * d0d13c5 51b84d69b Roll Fuchsia Mac SDK from qYE6uXjRtAxy7p5HB... to qk9nUlw83EeMMaWmE... (flutter/engine#38380) (flutter/flutter#117273) * 725049f 794370b9c Roll Fuchsia Linux SDK from PqyqxdbUFyd8xoYIP... to bloqad357AGI6lnOb... (flutter/engine#38381) (flutter/flutter#117276) * 49f3ca4 eeae936f9 Use canvaskit `toByteData` for unsupported videoFrame formats (flutter/engine#38361) (flutter/flutter#117279) * c0dddac Fix is canvas kit bool (flutter/flutter#116944) * d88d524 276327f7e Roll Fuchsia Mac SDK from qk9nUlw83EeMMaWmE... to DdU--deE0Xl4TQ2Bm... (flutter/engine#38383) (flutter/flutter#117286) * b7d9be0 747a9d8c7 Roll Skia from 7b0a9d9a3008 to 0362c030efa7 (9 revisions) (flutter/engine#38385) (flutter/flutter#117289) * 1233fc9 37387019b Roll Fuchsia Linux SDK from bloqad357AGI6lnOb... to mRBUNknZk43y-LHGS... (flutter/engine#38386) (flutter/flutter#117290) * a3a0048 3c6cab032 Roll Fuchsia Mac SDK from DdU--deE0Xl4TQ2Bm... to NLb_T58g0l_X46JEN... (flutter/engine#38387) (flutter/flutter#117295) * 420c6d6 Roll Flutter Engine from 3c6cab03274f to 58ab5277a7c4 (2 revisions) (flutter/flutter#117312) * d238bed Roll Plugins from cbcf507 to 840a049 (8 revisions) (flutter/flutter#117314) * 3eefb7a a9491515f Roll Skia from 0362c030efa7 to fc0ac31a46f8 (4 revisions) (flutter/engine#38399) (flutter/flutter#117317) * 9f9010f [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (flutter/flutter#116892) * 32da250 a12dadfda Roll Fuchsia Mac SDK from NLb_T58g0l_X46JEN... to NS4fVXM2KhKcZ1uyD... (flutter/engine#38400) (flutter/flutter#117319) * cb988c7 Add `indicatorColor` & `indicatorShape` to `NavigationRail`, `NavigationDrawer` and move these properties from destination to `NavigationBar` (flutter/flutter#117049) * 5fcb48d Fix `NavigationRail` highlight (flutter/flutter#117320) * 70f391d 7bc519375 Roll Skia from fc0ac31a46f8 to 46af4ad25426 (1 revision) (flutter/engine#38403) (flutter/flutter#117322) * 9f2c5d8 Support `flutter build web --wasm` (flutter/flutter#117075) * 55584ad Roll Flutter Engine from 7bc519375b7b to 45713ea10510 (2 revisions) (flutter/flutter#117330) * 4daff08 Roll Flutter Engine from 45713ea10510 to cba3a3990138 (5 revisions) (flutter/flutter#117336) * 1adc275 Bump min SDK to 2.19.0-0 (flutter/flutter#117345) * efadc34 Roll Flutter Engine from cba3a3990138 to 6de29d1cba70 (3 revisions) (flutter/flutter#117354) * b30947b roll packages (flutter/flutter#117226) * e625e5f 3330cce60 Roll Fuchsia Linux SDK from yGQvkNl85l1TSeuo9... to uKNwsaf92uZcX_QiY... (flutter/engine#38411) (flutter/flutter#117358) * 50a23d9 339791f19 Roll Skia from 8876daf17554 to e8c3fa6d7d2f (3 revisions) (flutter/engine#38413) (flutter/flutter#117366) * 7f7a877 Implemented Scrim Focus for BottomSheet (flutter/flutter#116743) * 38e3930 Exposed tooltip longPress action when available (flutter/flutter#117338) * 61fb6ea Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (flutter/flutter#117372) * c64dcbe Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (flutter/flutter#117396) * 8289ea6 Move a comment where it belongs (flutter/flutter#117385) * fa3777b Enable `sized_box_shrink_expand` lint (flutter/flutter#117371) * e0742eb [Android] Add spell check suggestions toolbar (flutter/flutter#114460) * 0220afd enable use_enums (flutter/flutter#117376) * d71fa88 Bump ossf/scorecard-action from 2.1.0 to 2.1.1 (flutter/flutter#117337) * 4591f05 roll packages (flutter/flutter#117357) * 46bb853 Revert "Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)" (flutter/flutter#117402) * 81bc54b Enable `use_colored_box` lint (flutter/flutter#117370) * fdd2d7d Sync analysis_options.yaml & cleanups (flutter/flutter#117327) * de35764 [Android] Bump template AGP and NDK versions (flutter/flutter#116536) * b308555 Enable `dangling_library_doc_comments` and `library_annotations` lints (flutter/flutter#117365) * b3c7fe3 enable test_ownership in presubmit (flutter/flutter#117414) * 014b8f7 Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (flutter/flutter#117421) * cd0f15a Add support for double tap and drag for text selection (flutter/flutter#109573) * e8e26b6 c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (flutter/flutter#117425) * a3e7fe3 de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (flutter/flutter#117429) * 1699351 4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (flutter/flutter#117433) * 9024c95 28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (flutter/flutter#117435) * cae7846 c9ee05b68 use min/max sandwich test on unit test bounds (flutter/engine#38435) (flutter/flutter#117442) * 6819f72 Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (flutter/flutter#117443) * f5c0716 4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (flutter/flutter#117454) * a7a5d14 Roll Plugins from 840a049 to 54fc206 (6 revisions) (flutter/flutter#117456) * 51a3e3a 1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision) (flutter/engine#38445) (flutter/flutter#117459) * d1244b7 da77d1a3a Roll Skia from 2e3ee507e838 to 7ad6f27aff57 (1 revision) (flutter/engine#38447) (flutter/flutter#117474) * 400b05a Manual package roll (flutter/flutter#117439) * 9a347fb Support safe area and scrolling in the NavigationDrawer (flutter/flutter#116995) * 2a50236 Add native unit tests to iOS and macOS templates (flutter/flutter#117147) * 1970bc9 cacheWidth cacheHeight support for canvaskit on web (flutter/flutter#117423) * ff347bf Fix `InkRipple` doesn't respect `rectCallback` when rendering ink circle (flutter/flutter#117395) * ddb7e43 Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (flutter/flutter#117489) * 8ff1b6e Fix Scaffold bottomSheet null exceptions (flutter/flutter#117008) * 2931e50 Handle the case of no selection rects (flutter/flutter#117419) * 39fa011 Revert "Add support for double tap and drag for text selection (#109573)" (flutter/flutter#117497) * b8b3567 Remove single-view assumption from widgets library (flutter/flutter#117480) * ca7ca3b Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (flutter/flutter#117499) * 9fb1ae8 [iOS] Add task for spell check integration test (flutter/flutter#116222)
esouthren
pushed a commit
that referenced
this pull request
Jan 30, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (#117783) * 3460f34 [fuchsia] Set presentation interval (flutter/engine#38549) (#117785) * Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788) * 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (#117790) * Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795) * e012dc8 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (#117799) * 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (#117800) * e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (#117802) * af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (#117804) * 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (#117805) * d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (#117824) * Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830) * 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966 [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (#117832) * Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (#117834) * 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (#117840) * 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (#117846) * Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (#117856) * 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (#117858) * 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (#117863) * e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (#117865) * 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (#117868) * 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (#117874) * Updated to tokens v0.150. (#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (#117923) * 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a7 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e8 [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (#117503)" (#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (#117661) * fix typos (#117592) * c0b3f8f Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (#117931) * Add convenience constructors for SliverList (#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80 [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (#117935) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c4685 Roll quiver to 3.2.1 (flutter/engine#38617) (#117942) * Send text direction in selection rects (#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (#117940) * roll packages (#118001) * [Android] Increase timeout duration for spell check integration test (#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c4685 to cdd3bf2 (8 revisions) (#118014) * 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dc Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440cc fix roll (flutter/engine#38635) * 87bdde8 Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf2 make DisplayListFlags constexpr throughout (flutter/engine#38649) * 6051576 [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (#118016) * 35b7dee [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (#118017) * b9b0193 Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (#118018) * a01548f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (#118039) * bb40152 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (#118042) * Avoid using `TextAffinity` in `TextBoundary` (#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (#118048) * 5bd90d6 Consider more roles as text (flutter/engine#38645) (#118049) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a Remove single view assumptions from `window.dart` (flutter/engine#38453) (#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (#118183) * Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (#118125) * c582547 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b4 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (#117716) * Roll Flutter Engine from 03609b4 to b5513d7 (2 revisions) (#118186) * fd5a96e Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7 to 5bdb04f (2 revisions) (#118187) * e208090 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (#118189) * Update to Xcode 14.2 (#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (#115337) * Roll Flutter Engine from 51baed6 to 5df0072 (3 revisions) (#118192) * 1812863 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (#118130) * eb5c6f0 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (#118197) * Update `ListTile` to support Material 3 (#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add #99933 HTML workaround. * 3a7d886 Re-enable UIA text/range provider unit tests (flutter/engine#38718) (#118201) * Fix path for require.js (#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d2 Roll flutter/packages to 25454e (flutter/engine#38685) (#118205) * Roll Flutter Engine from ee0c4d2 to 264aa03 (2 revisions) (#118208) * 5a39a88 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa03 Revert "Add CI builder for windows-arm64. (#38394)" (flutter/engine#38729) * 9c0b187 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (#118210) * add closed/open focus traversal; use open on web (#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187 to 716bb91 (3 revisions) (#118220) * b6720a5 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb91 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (#118026) * Allow select cases to be numbers (#116625) * [Impeller Scene] Add SceneC asset importing (#118157) * Add a comment about repeat event + fix typos (#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (#116894) * Roll Flutter Engine from 716bb91 to 687e3cb (2 revisions) (#118242) * 24ee5c1 Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (#117990) * remove unsound mode web test (#118256) * Update `CupertinoPicker` example (#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (#118117) * Add option for opting out of enter route snapshotting. (#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (#118272) * Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (#118274) * ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (#118287) * Fix Finnish TimeOfDate format (#118204) * init * add test * Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (#118289) * b9a7234 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c removed forbidden skia include (flutter/engine#38761) (#118296) * 8d7beac Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (#118297) * 6256f05 Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f91 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab7 Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (#118335) * Roll Flutter Engine from ee76ab7 to cccaae2 (3 revisions) (#118349) * 5ec03d7 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead94 delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e0 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (#118355) * Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (#118357) * 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d686 Add CI builder for windows-arm64. (#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (#111570) * Marks Mac channels_integration_test to be unflaky (#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (#118322) * docs: update docs about color property in material card (#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (#118185) * [M3] Add error state support for side property of CheckBox (#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (#118216) * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (#118359) * Roll Flutter Engine from 4a8d686 to c01465a (9 revisions) (#118409) * 2d2c5e7 Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954 fix canvas drawLine bugs (flutter/engine#38753) * 2b024cb [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea1 Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f5 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c0 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e9 Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa79 Revert "fix canvas drawLine bugs (#38753)" (flutter/engine#38815) * c01465a Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 6880157 fixed glfw example for arm64 (flutter/engine#38426) (#118413) * Use correct API docs link in create --sample help message (#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 6880157 to 35cfe91 (2 revisions) (#118415) * e9b7a2d [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe91 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26ba Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (#118420) * add generated_plugins.cmake (#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: #118324 Bug: #118327 Bug: #118328 * 99509a7 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (#118425) * Roll Flutter Engine from 99509a7 to f3f0536 (2 revisions) (#118429) * 091c785 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f0536 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * a62d253 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (#118435) * dfa0327 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (#118436) * 07603c6 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (#118439) * Fix copying/applying font fallback with package (#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec6089 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (#118445) * 970889b Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (#118448) * a512ceb Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (#116940) * Marks Mac_ios spell_check_test to be unflaky (#117743) * [Linux] Add a 'flutter run' console output test (#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (#116778) * e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797) * fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (#117940) * roll packages (#118001) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (#118157) * roll packages (#118117) * roll packages (#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d5979 Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix --------- Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cd0f15a #109573
Pre-launch Checklist
///).