dev/bots/prepare_packages: cleanup #113717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing logic so helpful errors show up before exception Handle the (valid) case where temp_dir isn't provided Remove gratuitous static helper on Branch
kevmoo
commented
Oct 19, 2022
kevmoo
commented
Oct 19, 2022
kevmoo
commented
Oct 19, 2022
CaseyHillers
approved these changes
Oct 19, 2022
Contributor
CaseyHillers
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
This was referenced Oct 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing logic so helpful errors show up before exception
Handle the (valid) case where temp_dir isn't provided
Remove gratuitous static helper on Branch