Skip to content

Conversation

@gspencergoog
Copy link
Contributor

Description

This adds a behavior attribute to TapRegion to allow it to control how each region reacts to hit tests. It defaults to HitTestBehavior.deferToChild, which is the existing behavior.

Related Issues

Tests

  • Added tests to make sure behavior is handled correctly.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 18, 2022
@gspencergoog gspencergoog force-pushed the add_tap_region_behavior branch from dea81ff to 7d7003d Compare October 18, 2022 19:24
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 18, 2022

auto label is removed for flutter/flutter, pr: 113634, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 18, 2022

auto label is removed for flutter/flutter, pr: 113634, due to Validations Fail.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2022
@auto-submit auto-submit bot merged commit 6d67fbb into flutter:master Oct 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 19, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants