Make TextEditingDelta diagnosticable and override debugFillProperties for concrete TextEditingDelta implementations #113395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Oct 13, 2022
Contributor
|
But in case you want to better incorporate this into widgets consider using |
bleroux
reviewed
Oct 14, 2022
Comment on lines
75
to
83
| expect( | ||
| const TextEditingDeltaInsertion( | ||
| oldText: 'hello worl', | ||
| textInserted: 'd', | ||
| insertionOffset: 10, | ||
| selection: TextSelection.collapsed(offset: 11), | ||
| composing: TextRange.empty).toString(), | ||
| equals('TextEditingDeltaInsertion(oldText: hello worl, textInserted: d, insertionOffset: 10, selection: TextSelection.collapsed(offset: 11, affinity: TextAffinity.downstream, isDirectional: false), composing: TextRange(start: -1, end: -1))') | ||
| ); |
Contributor
There was a problem hiding this comment.
Just my 2 cents about readability, consider formatting all calls to expect in this way:
expect(
const TextEditingDeltaInsertion(
oldText: 'hello worl',
textInserted: 'd',
insertionOffset: 10,
selection: TextSelection.collapsed(offset: 11),
composing: TextRange.empty,
).toString(),
equals(
'TextEditingDeltaInsertion(oldText: hello worl, textInserted: d, insertionOffset: 10, selection: TextSelection.collapsed(offset: 11, affinity: TextAffinity.downstream, isDirectional: false), composing: TextRange(start: -1, end: -1))',
),
);
LongCatIsLooong
approved these changes
Oct 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 17, 2022
…operties for concrete TextEditingDelta implementations (flutter/flutter#113395)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 17, 2022
…operties for concrete TextEditingDelta implementations (flutter/flutter#113395)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 19, 2022
…operties for concrete TextEditingDelta implementations (flutter/flutter#113395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
TextEditingDeltamixinDiagnosticableand adds overrides fordebugFillPropertiesforTextEditingDeltaInsertion,TextEditingDeltaDeletion,TextEditingDeltaReplacement, andTextEditingDeltaNonTextUpdate.Fixes #113394
Pre-launch Checklist
///).