Skip to content

cherry-picks "fixes FadeInImage for an edge case (#111035)" #113035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 1 commit into from
Oct 18, 2022
Merged

cherry-picks "fixes FadeInImage for an edge case (#111035)" #113035

godofredoc merged 1 commit into from
Oct 18, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Oct 6, 2022 •
edited
Loading

cp issue #113036

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 6, 2022
@chunhtai chunhtai mentioned this pull request Oct 6, 2022
Closed
@godofredoc godofredoc self-requested a review October 17, 2022 20:07
@godofredoc godofredoc merged commit eebbb0e into flutter:flutter-3.2-candidate.5 Oct 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
eebbb0e fixes FadeInImage for an edge case (#111035) (flutter/flutter…
064d9bb 
…#113035)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
eebbb0e2e fixes FadeInImage for an edge case (#111035) (flutter/flutt…
8351d42 
…er#113035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @godofredoc @werainkhatri