Reland "Migrate package/flutter to JS static interop. (#111315)" #112418
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@eyebrowsoffire @ditman ptal, just getting this out for review again. There won't be any code changes, I just had to fix some internal build rules. I will ensure a green internal presubmit before landing. |
ditman
left a comment
There was a problem hiding this comment.
The Google Tests check is failing, do you need a g3fix for this? (possibly to add a dependency on package:js?)
|
test-exempt: code refactor with no semantic change |
1acd223 to
5fca4b2
Compare
Relands 6906493
Which was reverted here: #112247 (comment)