Update pod repo to pull the latest Flutter pods in plugin_lint_mac
#112237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Sep 22, 2022
|
|
||
| - name: Mac plugin_lint_mac | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # Flaky https://github.com/flutter/flutter/issues/112146 |
Member
Author
There was a problem hiding this comment.
Make this run in presubmit.
Contributor
There was a problem hiding this comment.
Do you want this as a temp presubmit check validation (seems it passes) or want to remove the flake flag as it is in this PR? Wondering if you want to have this target to go through the flake validation workflow.
Member
Author
There was a problem hiding this comment.
I was going to revert it in this PR in case this didn't solve the flake. Just first wanted it to run in try, which I think it won't if bringup is true?
It passed:
https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/18408
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Sep 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the latest publish Flutter pods are downloaded to use in the plugin
pod lib linttests. I think some builders have an old version of FlutterMacOS cached, which does not contain an arm slice.Fixes #112146 (hopefully).
I recently had to do something similar in #111714.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.