Skip to content

Fixed an iconTheme lerping problem with ChipThemeData. #112216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 22, 2022
Merged

Fixed an iconTheme lerping problem with ChipThemeData. #112216

auto-submit merged 2 commits into from
Sep 22, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Sep 22, 2022 •
edited
Loading

The current ChipThemeData.lerp doesn't handle a null iconTheme very well. If both ChipThemeData.iconTheme's are null it creates a new default IconThemeData instead of null. This can cause some weird icon size and color changes during a theme lerp (like from light to dark themes). This PR fixes that.

Fixes: #111998

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 22, 2022
goderbauer
goderbauer approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin darrenaustin added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
@auto-submit auto-submit bot merged commit bef6f30 into flutter:master Sep 22, 2022
@darrenaustin darrenaustin deleted the chip_theme_lerp branch September 22, 2022 22:47
This was referenced Sep 23, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
bef6f30 Fixed an iconTheme lerping problem with ChipThemeData. (flutt…
bb47bcb 
…er/flutter#112216)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
bef6f30 Fixed an iconTheme lerping problem with ChipThemeData. (flutt…
50b815a 
…er/flutter#112216)
@rydmike rydmike mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assist Chip Icon enlarges when switching from light to dark mode

2 participants

@darrenaustin @goderbauer