Revert file naming convention of .aar files to support fuzzy matching in build.gradle #112149

JunhuaLin · 2022-09-22T06:40:23Z

Revert file naming convention of .aar files to support fuzzy matching in build.gradle on using maven-publish

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… in build.gradle #111643

google-cla · 2022-09-22T06:40:27Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

JunhuaLin · 2022-09-22T07:41:53Z

build result:

JunhuaLin · 2022-09-22T07:42:55Z

Jasguerrero · 2022-09-22T20:27:23Z

Could you take a look? @GaryQian

JunhuaLin · 2022-09-24T09:10:15Z

Could you take a look? @GaryQian

GaryQian

This PR seems to be missing some of the testing code removed in the original PR. Can you make sure this PR fully reverts the original PR? Tests that have comments "mimic the AGP plugin" seem to be missing. Things like the JDK bump can stay unless it causes incompatibility issues. This way we have more guarantees we are not introducing new bugs.

JunhuaLin · 2022-09-25T12:59:40Z

This PR seems to be missing some of the testing code removed in the original PR. Can you make sure this PR fully reverts the original PR? Tests that have comments "mimic the AGP plugin" seem to be missing. Things like the JDK bump can stay unless it causes incompatibility issues. This way we have more guarantees we are not introducing new bugs.

This PR is not intended to restore all the original PR1 changes

This PR modifies the use of Maven-Publish to produce the correct AAR based on #101276

The Maven-Publish part of the code has been tested in #101276

This PR ensures that the code is correct without having to adjust the Maven-Publish-related test code

JunhuaLin · 2022-09-27T02:26:38Z

This PR seems to be missing some of the testing code removed in the original PR. Can you make sure this PR fully reverts the original PR? Tests that have comments "mimic the AGP plugin" seem to be missing. Things like the JDK bump can stay unless it causes incompatibility issues. This way we have more guarantees we are not introducing new bugs.

The JDK version configuration in the CI file is not concerned, the latest flutter:master branch has been adjusted

JunhuaLin · 2022-09-27T06:26:34Z

@GaryQian
When can this PR be merged to the master branch？

auto-submit · 2022-09-27T06:45:09Z

auto label is removed for flutter/flutter, pr: 112149, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-09-27T06:45:10Z

auto label is removed for flutter/flutter, pr: 112149, due to Validations Fail.

GaryQian · 2022-09-27T06:54:10Z

This still needs one more review to be landable! I've tagged a few others.

JunhuaLin · 2022-09-27T07:26:37Z

auto label is removed for flutter/flutter, pr: 112149, due to Validations Fail.

This still needs one more review to be landable! I've tagged a few others.

There seems to be a need for approving comments LGTM

JunhuaLin · 2022-09-28T01:48:56Z

Could you take a look? @christopherfujino @stuartmorgan @camsim99

JunhuaLin · 2022-09-28T07:10:24Z

Hope to deal with as soon as possible, affect the upgrade to the latest version！
We don't want to stay at 3.0.5 for too long！
This problem is holding up the build flutter.

christopherfujino

RSLGTM

christopherfujino · 2022-09-28T16:54:13Z

@JunhuaLin it looks like you have a test failure, however:

02:08 +13 -1: test\integration.shard\gradle_non_android_plugin_test.dart: Flutter app that depends on a non-Android plugin can still build for Android [E]
  Expected: a file system entity that exists
    Actual: LocalFile:<LocalFile: 'C:\b\s\w\ir\x\t\flutter_flutter_plugin_test.5951ddc1\ios_only\example\build\app\outputs\apk\release\app-release.apk'>
     Which: does not exist
  
  package:test_api                                                 expect
  test\integration.shard\gradle_non_android_plugin_test.dart 90:5  main.<fn>
  dart:async                                                       runZoned
  test\src\common.dart 197:14                                      testWithoutContext.<fn>
  test\src\common.dart 166:18                                      test.<fn>

auto-submit · 2022-09-28T16:55:11Z

auto label is removed for flutter/flutter, pr: 112149, due to - The status or check suite Windows tool_integration_tests_4_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

JunhuaLin · 2022-09-29T03:09:33Z

@JunhuaLin it looks like you have a test failure, however:

02:08 +13 -1: test\integration.shard\gradle_non_android_plugin_test.dart: Flutter app that depends on a non-Android plugin can still build for Android [E]
  Expected: a file system entity that exists
    Actual: LocalFile:<LocalFile: 'C:\b\s\w\ir\x\t\flutter_flutter_plugin_test.5951ddc1\ios_only\example\build\app\outputs\apk\release\app-release.apk'>
     Which: does not exist
  
  package:test_api                                                 expect
  test\integration.shard\gradle_non_android_plugin_test.dart 90:5  main.<fn>
  dart:async                                                       runZoned
  test\src\common.dart 197:14                                      testWithoutContext.<fn>
  test\src\common.dart 166:18                                      test.<fn>

This test failure has nothing to do with my PR
Let me merge the flutter:master code again

JunhuaLin · 2022-09-29T03:14:28Z

Should I not merge the master code？
Should I just keep my commit？

JunhuaLin · 2022-09-29T03:46:09Z

Now，it‘s fine~
@christopherfujino @GaryQian

AesSedai101 · 2022-09-29T07:03:24Z

this change is going to cause add to app modules with multiple native dependencies to fail because of how gradle 7 does dependency resolution. Please test that case as well

JunhuaLin · 2022-09-29T08:47:17Z

this change is going to cause add to app modules with multiple native dependencies to fail because of how gradle 7 does dependency resolution. Please test that case as well

Can you give a detailed description demo？

OR

Does this mean that there are multiple flutter plugin dependencies?

this case：it's ok

module dependency：

app --> module_test --> flutterboost
                 |
                  --> shared_preferences_android

build aar file tree:

flutter build aar --no-debug --no-profile --build-number 1.0.0

└── host
    └── outputs
        └── repo
            ├── com
            │   ├── example
            │   │   └── module_test
            │   │       └── flutter_release
            │   │           ├── 1.0.0
            │   │           │   ├── flutter_release-1.0.0.aar
            │   │           │   ├── flutter_release-1.0.0.aar.md5
            │   │           │   ├── flutter_release-1.0.0.aar.sha1
            │   │           │   ├── flutter_release-1.0.0.aar.sha256
            │   │           │   ├── flutter_release-1.0.0.aar.sha512
            │   │           │   ├── flutter_release-1.0.0.module
            │   │           │   ├── flutter_release-1.0.0.module.md5
            │   │           │   ├── flutter_release-1.0.0.module.sha1
            │   │           │   ├── flutter_release-1.0.0.module.sha256
            │   │           │   ├── flutter_release-1.0.0.module.sha512
            │   │           │   ├── flutter_release-1.0.0.pom
            │   │           │   ├── flutter_release-1.0.0.pom.md5
            │   │           │   ├── flutter_release-1.0.0.pom.sha1
            │   │           │   ├── flutter_release-1.0.0.pom.sha256
            │   │           │   └── flutter_release-1.0.0.pom.sha512
            │   │           ├── maven-metadata.xml
            │   │           ├── maven-metadata.xml.md5
            │   │           ├── maven-metadata.xml.sha1
            │   │           ├── maven-metadata.xml.sha256
            │   │           └── maven-metadata.xml.sha512
            │   └── idlefish
            │       └── flutterboost
            │           └── flutter_boost_release
            │               ├── 1.0.0
            │               │   ├── flutter_boost_release-1.0.0.aar
            │               │   ├── flutter_boost_release-1.0.0.aar.md5
            │               │   ├── flutter_boost_release-1.0.0.aar.sha1
            │               │   ├── flutter_boost_release-1.0.0.aar.sha256
            │               │   ├── flutter_boost_release-1.0.0.aar.sha512
            │               │   ├── flutter_boost_release-1.0.0.module
            │               │   ├── flutter_boost_release-1.0.0.module.md5
            │               │   ├── flutter_boost_release-1.0.0.module.sha1
            │               │   ├── flutter_boost_release-1.0.0.module.sha256
            │               │   ├── flutter_boost_release-1.0.0.module.sha512
            │               │   ├── flutter_boost_release-1.0.0.pom
            │               │   ├── flutter_boost_release-1.0.0.pom.md5
            │               │   ├── flutter_boost_release-1.0.0.pom.sha1
            │               │   ├── flutter_boost_release-1.0.0.pom.sha256
            │               │   └── flutter_boost_release-1.0.0.pom.sha512
            │               ├── maven-metadata.xml
            │               ├── maven-metadata.xml.md5
            │               ├── maven-metadata.xml.sha1
            │               ├── maven-metadata.xml.sha256
            │               └── maven-metadata.xml.sha512
            └── io
                └── flutter
                    └── plugins
                        └── sharedpreferences
                            └── shared_preferences_android_release
                                ├── 1.0.0
                                │   ├── shared_preferences_android_release-1.0.0.aar
                                │   ├── shared_preferences_android_release-1.0.0.aar.md5
                                │   ├── shared_preferences_android_release-1.0.0.aar.sha1
                                │   ├── shared_preferences_android_release-1.0.0.aar.sha256
                                │   ├── shared_preferences_android_release-1.0.0.aar.sha512
                                │   ├── shared_preferences_android_release-1.0.0.module
                                │   ├── shared_preferences_android_release-1.0.0.module.md5
                                │   ├── shared_preferences_android_release-1.0.0.module.sha1
                                │   ├── shared_preferences_android_release-1.0.0.module.sha256
                                │   ├── shared_preferences_android_release-1.0.0.module.sha512
                                │   ├── shared_preferences_android_release-1.0.0.pom
                                │   ├── shared_preferences_android_release-1.0.0.pom.md5
                                │   ├── shared_preferences_android_release-1.0.0.pom.sha1
                                │   ├── shared_preferences_android_release-1.0.0.pom.sha256
                                │   └── shared_preferences_android_release-1.0.0.pom.sha512
                                ├── maven-metadata.xml
                                ├── maven-metadata.xml.md5
                                ├── maven-metadata.xml.sha1
                                ├── maven-metadata.xml.sha256
                                └── maven-metadata.xml.sha512

pom dependencies:

module_test pom file:

<project ...>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.example.module_test</groupId>
  <artifactId>flutter_release</artifactId>
  <version>1.0.0</version>
  <packaging>aar</packaging>

  <dependencies>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-4b591e17d288447f118300754073c9f1d9a4393a</version>
      <scope>compile</scope>
    </dependency>
  
 ......

    <dependency>
      <groupId>io.flutter.plugins.sharedpreferences</groupId>
      <artifactId>shared_preferences_android_release</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>

    <dependency>
      <groupId>com.idlefish.flutterboost</groupId>
      <artifactId>flutter_boost_release</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

flutterboost pom file:

<project ...>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.idlefish.flutterboost</groupId>
  <artifactId>flutter_boost_release</artifactId>
  <version>1.0.0</version>
  <packaging>aar</packaging>
  <dependencies>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-4b591e17d288447f118300754073c9f1d9a4393a</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

shared_preferences_android pom file:

<project ...>
  <modelVersion>4.0.0</modelVersion>
  <groupId>io.flutter.plugins.sharedpreferences</groupId>
  <artifactId>shared_preferences_android_release</artifactId>
  <version>1.0.0</version>
  <packaging>aar</packaging>
  <dependencies>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-4b591e17d288447f118300754073c9f1d9a4393a</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

The dependencies in the POM are complete

AesSedai101 · 2022-09-29T10:01:50Z

If you have your add to app project depending on another plugin with a native dependency (in your case, flutterboost depending on shared_preferences) via the pubspec, the dependencies in the POM uses the new classifier mechanism.

For example., in my main add to app module, I use logging_to_logcat, which gets included like this:

   <dependency>
      <groupId>com.logger.logging_to_logcat</groupId>
      <artifactId>logging_to_logcat</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>

with the -debug and -release classifiers mapping to the flavours.

so, if you don't publish the artifacts in the new way with the classifiers, you will need to declare all Flutter dependencies with a native component manually in the gradle file of your native project.

JunhuaLin · 2022-09-29T16:45:36Z

If you have your add to app project depending on another plugin with a native dependency (in your case, flutterboost depending on shared_preferences) via the pubspec, the dependencies in the POM uses the new classifier mechanism.

For example., in my main add to app module, I use logging_to_logcat, which gets included like this:
   <dependency>
      <groupId>com.logger.logging_to_logcat</groupId>
      <artifactId>logging_to_logcat</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>
with the -debug and -release classifiers mapping to the flavours.

so, if you don't publish the artifacts in the new way with the classifiers, you will need to declare all Flutter dependencies with a native component manually in the gradle file of your native project.

I created the following dependency structure：

app --> module_test --> flutterboost --> okhttp
                             |
                              --> logging_to_logcat

flutterboost depending on logging_to_logcat and okhttp

flutterboost pubspec file:

name: flutter_boost
description: A next-generation Flutter-Native hybrid solution. FlutterBoost is a Flutter plugin which enables hybrid integration of Flutter for your existing native apps with minimum efforts.
version: 3.0.0

homepage: https://github.com/alibaba/flutter_boost

environment:
  sdk: '>=2.12.0 <3.0.0'

dependencies:
  flutter:
    sdk: flutter
  collection: ^1.16.0
  logging_to_logcat: ^0.1.1               <---- plugin

dev_dependencies:
  flutter_lints: ^2.0.1
  flutter_test:
    sdk: flutter
  pigeon: ^3.2.9

flutter:
  plugin:
    platforms:
      android:
        package: com.idlefish.flutterboost
        pluginClass: FlutterBoostPlugin
      ios:
        pluginClass: FlutterBoostPlugin

flutterboost gradle file:

group 'com.idlefish.flutterboost'
version '1.0-SNAPSHOT'

buildscript {
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:7.0.4'
    }
}

rootProject.allprojects {
    repositories {
        google()
        jcenter()
    }
}

apply plugin: 'com.android.library'

android {
    compileSdkVersion 31
    buildToolsVersion '30.0.2'
    defaultConfig {
        minSdkVersion 16
        targetSdkVersion 31
        testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
    }
    lintOptions {
        disable 'InvalidPackage'
        abortOnError false
    }

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

dependencies {
    compileOnly 'com.google.android.material:material:1.0.0'
    compileOnly 'com.alibaba:fastjson:1.2.41'
    implementation 'com.squareup.okhttp3:okhttp:3.5.0'                  <------ native
}

ext {
    groupId = 'com.taobao.fleamarket'
    artifactId = "FlutterBoost"
}

.flutter-plugins-dependencies file:Plugin dependent plugins also compile normally，look this:

build aar file tree:

└── host
    └── outputs
        └── repo
            └── com
                ├── example
                │   └── module_test
                │       └── flutter_release
                │           ├── 1.0
                │           │   ├── flutter_release-1.0.aar
                │           │   ├── flutter_release-1.0.aar.md5
                │           │   ├── flutter_release-1.0.aar.sha1
                │           │   ├── flutter_release-1.0.pom
                │           │   ├── flutter_release-1.0.pom.md5
                │           │   └── flutter_release-1.0.pom.sha1
                │           ├── maven-metadata.xml
                │           ├── maven-metadata.xml.md5
                │           └── maven-metadata.xml.sha1
                ├── idlefish
                │   └── flutterboost
                │       └── flutter_boost_release
                │           ├── 1.0
                │           │   ├── flutter_boost_release-1.0.aar
                │           │   ├── flutter_boost_release-1.0.aar.md5
                │           │   ├── flutter_boost_release-1.0.aar.sha1
                │           │   ├── flutter_boost_release-1.0.pom
                │           │   ├── flutter_boost_release-1.0.pom.md5
                │           │   └── flutter_boost_release-1.0.pom.sha1
                │           ├── maven-metadata.xml
                │           ├── maven-metadata.xml.md5
                │           └── maven-metadata.xml.sha1
                └── logger
                    └── logging_to_logcat
                        └── logging_to_logcat_release
                            ├── 1.0
                            │   ├── logging_to_logcat_release-1.0.aar
                            │   ├── logging_to_logcat_release-1.0.aar.md5
                            │   ├── logging_to_logcat_release-1.0.aar.sha1
                            │   ├── logging_to_logcat_release-1.0.pom
                            │   ├── logging_to_logcat_release-1.0.pom.md5
                            │   └── logging_to_logcat_release-1.0.pom.sha1
                            ├── maven-metadata.xml
                            ├── maven-metadata.xml.md5
                            └── maven-metadata.xml.sha1

module_test pom file:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.example.module_test</groupId>
  <artifactId>flutter_release</artifactId>
  <version>1.0</version>
  <packaging>aar</packaging>
  <dependencies>
    <dependency>
      <groupId>com.logger.logging_to_logcat</groupId>
      <artifactId>logging_to_logcat_release</artifactId>
      <version>1.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>com.idlefish.flutterboost</groupId>
      <artifactId>flutter_boost_release</artifactId>
      <version>1.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-d3ea636dc5d16b56819f3266241e1f708979c233</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>armeabi_v7a_release</artifactId>
      <version>1.0.0-d3ea636dc5d16b56819f3266241e1f708979c233</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>arm64_v8a_release</artifactId>
      <version>1.0.0-d3ea636dc5d16b56819f3266241e1f708979c233</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>x86_64_release</artifactId>
      <version>1.0.0-d3ea636dc5d16b56819f3266241e1f708979c233</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

flutterboost pom file:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.idlefish.flutterboost</groupId>
  <artifactId>flutter_boost_release</artifactId>
  <version>1.0</version>
  <packaging>aar</packaging>
  <dependencies>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-4b591e17d288447f118300754073c9f1d9a4393a</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>com.squareup.okhttp3</groupId>
      <artifactId>okhttp</artifactId>
      <version>3.5.0</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>com.logger.logging_to_logcat</groupId>
      <artifactId>logging_to_logcat_release</artifactId>
      <version>1.0</version>
      <scope>runtime</scope>
    </dependency>
  </dependencies>
</project>

logging_to_logcat pom file:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.logger.logging_to_logcat</groupId>
  <artifactId>logging_to_logcat_release</artifactId>
  <version>1.0</version>
  <packaging>aar</packaging>
  <dependencies>
    <dependency>
      <groupId>io.flutter</groupId>
      <artifactId>flutter_embedding_release</artifactId>
      <version>1.0.0-4b591e17d288447f118300754073c9f1d9a4393a</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.jetbrains.kotlin</groupId>
      <artifactId>kotlin-stdlib-jdk7</artifactId>
      <version>1.6.10</version>
      <scope>runtime</scope>
    </dependency>
  </dependencies>
</project>

This case is fine~

GaryQian · 2022-09-30T00:18:28Z

@AesSedai101 Can you confirm that @JunhuaLin 's explanation here resolves your concern?

JunhuaLin · 2022-09-30T01:56:13Z

Why tree is currently broken?
I shouldn't merge the master, I should use Rebase, right?

GaryQian · 2022-09-30T02:34:35Z

Yes, you should use rebase, but don't worry about the tree being broken, it is not your fault, it should become green again soon (it is green now). That check simply reflects the build status of tip-of-tree.

JunhuaLin · 2022-09-30T03:25:08Z

Yes, you should use rebase, but don't worry about the tree being broken, it is not your fault, it should become green again soon (it is green now). That check simply reflects the build status of tip-of-tree.

Ok, I see~

Can my PR be merged in this case?

We want to use the latest version as soon as possible

AesSedai101 · 2022-09-30T07:07:59Z

Can you confirm that @JunhuaLin 's explanation here resolves your concern?

That is not the behaviour I saw on my side, but it's possible that my environment is in a broken state

JunhuaLin · 2022-09-30T07:31:28Z

Can you confirm that @JunhuaLin 's explanation here resolves your concern?

That is not the behaviour I saw on my side, but it's possible that my environment is in a broken state

I'm not sure I understand your situation.
My changes are consistent with 3.0.5 and earlier features for build aar，so there should be no negative effect！

You can use my branch master version to verify your problem
or：
Can you reproduce your problem in 3.0.5 or earlier?
Can you provide a complete minimum reproducible code example ？

GaryQian · 2022-10-02T16:20:12Z

@AesSedai101 Ping on @JunhuaLin 's questions

JunhuaLin · 2022-10-04T03:27:40Z

Can my PR be released with 3.4.0 @GaryQian

…matching in build.gradle (flutter/flutter#112149)

… in build.gradle (flutter#112149)

JunhuaLin and others added 2 commits September 22, 2022 14:36

Revert file naming convention of .aar files to support fuzzy matching…

7577ff8

… in build.gradle #111643

Merge branch 'flutter:master' into master

8eae740

flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 22, 2022

JunhuaLin mentioned this pull request Sep 22, 2022

Revert file naming convention of .aar files to support fuzzy matching in build.gradle #111643

Closed

JunhuaLin changed the title ~~Revert file naming convention of .aar files to support fuzzy matching in build.gradle #111643~~ Revert file naming convention of .aar files to support fuzzy matching in build.gradle Sep 22, 2022

GaryQian reviewed Sep 24, 2022

View reviewed changes

Merge branch 'flutter:master' into master

663ef39

GaryQian approved these changes Sep 27, 2022

View reviewed changes

GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022

GaryQian requested review from christopherfujino and stuartmorgan-g September 27, 2022 06:53

GaryQian requested a review from camsim99 September 27, 2022 06:54

Merge branch 'flutter:master' into master

090d5da

christopherfujino approved these changes Sep 28, 2022

View reviewed changes

GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2022

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2022

Merge branch 'flutter:master' into master

5e518fd

Merge branch 'flutter:master' into master

c9dfa3a

Merge branch 'flutter:master' into master

099f405

GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2022

auto-submit bot merged commit 8e30cc9 into flutter:master Oct 4, 2022

This was referenced Oct 4, 2022

Roll Flutter from a4b246f2a88c to 55d67cc7d992 (20 revisions) flutter/packages#2674

Merged

Roll Flutter from a4b246f2a88c to 55d67cc7d992 (20 revisions) flutter/plugins#6534

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2022

8e30cc9 Revert file naming convention of .aar files to support fuzzy …

10c34c5

…matching in build.gradle (flutter/flutter#112149)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 4, 2022

8e30cc9 Revert file naming convention of .aar files to support fuzzy …

e4baf3d

…matching in build.gradle (flutter/flutter#112149)

wangmir mentioned this pull request Oct 17, 2022

[add-2-app] AAR build causes maven upload failing because of new classifier features. #113417

Closed

flutter-kim-json added a commit to flutter-kim-json/flutter that referenced this pull request Feb 20, 2023

Revert file naming convention of .aar files to support fuzzy matching…

19762ee

… in build.gradle (flutter#112149)

Revert file naming convention of .aar files to support fuzzy matching in build.gradle #112149

Revert file naming convention of .aar files to support fuzzy matching in build.gradle #112149

Uh oh!

Conversation

JunhuaLin commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Sep 22, 2022

Uh oh!

JunhuaLin commented Sep 22, 2022

Uh oh!

JunhuaLin commented Sep 22, 2022

Uh oh!

Jasguerrero commented Sep 22, 2022

Uh oh!

JunhuaLin commented Sep 24, 2022

Uh oh!

GaryQian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JunhuaLin commented Sep 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JunhuaLin commented Sep 27, 2022

Uh oh!

JunhuaLin commented Sep 27, 2022

Uh oh!

auto-submit bot commented Sep 27, 2022

Uh oh!

auto-submit bot commented Sep 27, 2022

Uh oh!

GaryQian commented Sep 27, 2022

Uh oh!

JunhuaLin commented Sep 27, 2022

Uh oh!

JunhuaLin commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JunhuaLin commented Sep 28, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Sep 28, 2022

Uh oh!

auto-submit bot commented Sep 28, 2022

Uh oh!

JunhuaLin commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JunhuaLin commented Sep 29, 2022

Uh oh!

JunhuaLin commented Sep 29, 2022

Uh oh!

AesSedai101 commented Sep 29, 2022

Uh oh!

JunhuaLin commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Can you give a detailed description demo？

OR

Does this mean that there are multiple flutter plugin dependencies?

module dependency：

build aar file tree:

pom dependencies:

Uh oh!

AesSedai101 commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JunhuaLin commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I created the following dependency structure：

flutterboost depending on logging_to_logcat and okhttp

.flutter-plugins-dependencies file:Plugin dependent plugins also compile normally，look this:

build aar file tree:

module_test pom file:

flutterboost pom file:

logging_to_logcat pom file:

Uh oh!

JunhuaLin commented Sep 22, 2022 •

edited

Loading

GaryQian left a comment •

edited

Loading

JunhuaLin commented Sep 25, 2022 •

edited

Loading

JunhuaLin commented Sep 28, 2022 •

edited

Loading

JunhuaLin commented Sep 29, 2022 •

edited

Loading

JunhuaLin commented Sep 29, 2022 •

edited

Loading

AesSedai101 commented Sep 29, 2022 •

edited

Loading

JunhuaLin commented Sep 29, 2022 •

edited

Loading

JunhuaLin commented Sep 30, 2022 •

edited

Loading

JunhuaLin commented Sep 30, 2022 •

edited

Loading

JunhuaLin commented Sep 30, 2022 •

edited

Loading