Skip to content

Always run Mac hostonly builds on x64 by default #112133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Sep 22, 2022
Merged

Always run Mac hostonly builds on x64 by default #112133

jmagman merged 1 commit into from
Sep 22, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 22, 2022 •
edited
Loading

Revert the change at #109889 that lets Mac hostonly builders run on either arm of x64 depending on capacity. Instead, always run on x64 until the ssl cert issue #112130 can be fixed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Sep 22, 2022
@jmagman jmagman requested a review from keyonghan as a code owner September 22, 2022 00:41
@jmagman jmagman requested a review from yjbanov September 22, 2022 00:42
@jmagman jmagman mentioned this pull request Sep 22, 2022
Closed
@jmagman
Copy link
Member Author

jmagman commented Sep 22, 2022

https://ci.chromium.org/p/flutter/builders/try/Mac%20dart_plugin_registry_test/15577 shows the cpu property is set to x86

jonahwilliams
jonahwilliams approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit c9edacb into flutter:master Sep 22, 2022
@jmagman jmagman deleted the mac-x64 branch September 22, 2022 00:50
@jmagman jmagman mentioned this pull request Sep 22, 2022
Closed
@jmagman
Copy link
Member Author

jmagman commented Sep 22, 2022

In post submit https://ci.chromium.org/p/flutter/builders/prod/Mac%20plugin_lint_mac/8949 the cpu property is set to x86

This was referenced Sep 22, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
e99a942 
…tter#112133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
040d7fa 
…tter#112133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
6e51dad 
…tter#112133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
a6909c0 
…tter#112133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
355d510 
…tter#112133)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
c9edacb Always run Mac hostonly builds on x64 by default (flutter/flu…
6ca5094 
…tter#112133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

@yjbanov yjbanov Awaiting requested review from yjbanov

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @jonahwilliams