Skip to content

Fix RenderEditable not able to update backgroundCursorColor when the user provides a new one #112045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmc merged 2 commits into from
Sep 22, 2022
Merged

Fix RenderEditable not able to update backgroundCursorColor when the user provides a new one #112045

justinmc merged 2 commits into from
Sep 22, 2022

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Sep 21, 2022

Close #112038. Please see description there.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 21, 2022
@fzyzcjy fzyzcjy mentioned this pull request Sep 21, 2022
Closed
7 tasks
jonahwilliams
jonahwilliams approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
justinmc
justinmc approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinmc justinmc merged commit 772bd43 into flutter:master Sep 22, 2022
This was referenced Sep 23, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
772bd43 Fix RenderEditable not able to update backgroundCursorColor w…
a1e7bc9 
…hen the user provides a new one (flutter/flutter#112045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
772bd43 Fix RenderEditable not able to update backgroundCursorColor w…
afdb2c8 
…hen the user provides a new one (flutter/flutter#112045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RenderObject is not updated when users provide new values

3 participants

@fzyzcjy @justinmc @jonahwilliams