Skip to content

Prevent committing text from triggering EditableText.onChanged #112010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 21, 2022
Merged

Prevent committing text from triggering EditableText.onChanged #112010

auto-submit merged 1 commit into from
Sep 21, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 20, 2022

Fixes #111651

Also prevents onChanged from being invoked when the input formater or a TextEditingController listener reverted the text change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 20, 2022
chunhtai
chunhtai approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2022
@auto-submit auto-submit bot merged commit 7270741 into flutter:master Sep 21, 2022
@LongCatIsLooong LongCatIsLooong deleted the committing-text-does-not-trigger-onchanged branch September 22, 2022 00:14
This was referenced Sep 22, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
8a27a5e 
flutter/flutter#112010)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
5a0042a 
flutter/flutter#112010)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
44016e7 
flutter/flutter#112010)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
1e28f3a 
flutter/flutter#112010)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
2d3968b 
flutter/flutter#112010)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
7270741 Prevent committing text from triggering EditableText.onChanged (
bb34b86 
flutter/flutter#112010)
@LinXunFeng LinXunFeng mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@justinmc justinmc Awaiting requested review from justinmc

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextField onChanged called twice after typing a letter followed by three digits on Android

2 participants

@LongCatIsLooong @chunhtai