Skip to content

Fix InputDecorator child vertical alignment #112003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 20, 2022
Merged

Fix InputDecorator child vertical alignment #112003

auto-submit merged 1 commit into from
Sep 20, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 20, 2022

Extracted from #110966

This change causes a lot of scuba failures so I'd like to isolate those failures.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 20, 2022
LongCatIsLooong
LongCatIsLooong commented Sep 20, 2022
View reviewed changes
packages/flutter/lib/src/material/input_decorator.dart Outdated
Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real change: subtracting densityOffset.dy from maxContentHeight.

@gspencergoog gspencergoog changed the title Fix InpputDecorator child vertical alignment Fix InputDecorator child vertical alignment Sep 20, 2022
gspencergoog
gspencergoog approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot merged commit c825fb1 into flutter:master Sep 20, 2022
@LongCatIsLooong LongCatIsLooong deleted the input-decorator-density branch September 20, 2022 22:13
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Sep 21, 2022

For rollers: the scuba failures are all expected: cl/475648159

This was referenced Sep 21, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
c825fb1 Fix InputDecorator child vertical alignment (flutter/flutte…
a7c9d69 
…r#112003)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
c825fb1 Fix InputDecorator child vertical alignment (flutter/flutte…
b45c53e 
…r#112003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @gspencergoog