Skip to content

Avoid sending zero transform semantic nodes to the engine #111843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 19, 2022
Merged

Avoid sending zero transform semantic nodes to the engine #111843

auto-submit merged 2 commits into from
Sep 19, 2022

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Sep 18, 2022

Addresses framework side of #110671

We should still fix this on the engine side - it's valid (but inefficient) for someone to send up a zero transform to the engine.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Sep 18, 2022
chunhtai
chunhtai approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Sep 19, 2022

I plan to file a CP request for this as well.

@auto-submit auto-submit bot merged commit 36a5a0f into flutter:master Sep 19, 2022
dnfield added a commit to dnfield/flutter that referenced this pull request Sep 19, 2022
@dnfield
Avoid sending zero transform semantic nodes to the engine (flutter#11…
8254151 
…1843)
@dnfield dnfield deleted the semantics branch September 19, 2022 20:41
itsjustkevin pushed a commit that referenced this pull request Sep 20, 2022
@dnfield
Avoid sending zero transform semantic nodes to the engine (#111843) (#…
0cf3ded 
…111914)
This was referenced Sep 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
36a5a0f Avoid sending zero transform semantic nodes to the engine (fl…
a4cd53c 
…utter/flutter#111843)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
36a5a0f Avoid sending zero transform semantic nodes to the engine (fl…
d689a2f 
…utter/flutter#111843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnfield @goderbauer @chunhtai