Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 16, 2022

Cherry-pick #111714

#111757

@jmagman jmagman self-assigned this Sep 16, 2022
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master September 16, 2022 18:14
@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 16, 2022
@google-cla
Copy link

google-cla bot commented Sep 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@itsjustkevin
Copy link
Contributor

@jmagman could you run this against flutter-3.2-candidate.5?

@jmagman jmagman changed the base branch from stable to flutter-3.2-candidate.5 September 16, 2022 19:44
@jmagman jmagman removed framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: scrolling Viewports, list views, slivers, etc. labels Sep 16, 2022
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants