Skip to content

Remove deprecated ScrollBehavior.buildViewportChrome #111715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Sep 19, 2022
Merged

Remove deprecated ScrollBehavior.buildViewportChrome #111715

auto-submit merged 8 commits into from
Sep 19, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 16, 2022 •
edited
Loading

This removes ScrollBehavior.buildViewportChrome

This deprecated class has reached end of life after the release of Flutter 3.3

Part of #111708
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-3-3

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Sep 16, 2022
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. c: API break Backwards-incompatible API changes labels Sep 16, 2022
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Sep 16, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Sep 16, 2022

Running internal testing to validate this is ready.

@Piinks Piinks requested a review from goderbauer September 16, 2022 23:12
@Piinks Piinks changed the title WIP - Remove deprecated ScrollBehavior.buildViewportChrome Remove deprecated ScrollBehavior.buildViewportChrome Sep 16, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Sep 16, 2022

Customers are migrated and ready

goderbauer
goderbauer approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 19, 2022

auto label is removed for flutter/flutter, pr: 111715, Failed to merge pr#: 111715 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Pull Request is not mergeable, locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]).

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit 5332295 into flutter:master Sep 19, 2022
This was referenced Sep 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
5332295 Remove deprecated ScrollBehavior.buildViewportChrome (flutter…
2bf1e9a 
…/flutter#111715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
5332295 Remove deprecated ScrollBehavior.buildViewportChrome (flutter…
7da647a 
…/flutter#111715)
ghost
ghost reviewed Sep 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/flutter/lib/fix_data.yaml

@ghost ghost mentioned this pull request Sep 23, 2022
Closed
@Piinks Piinks mentioned this pull request Sep 28, 2022
Merged
3 tasks
@dddrop dddrop mentioned this pull request Feb 6, 2023
Merged
AlexV525 added a commit to fluttercandies/flutter_wechat_assets_picker that referenced this pull request Feb 7, 2023
@dddrop @AlexV525
🚀 Migrate to Flutter 3.7 (#410)
e3bf8e9 
- Migrate `extended_image` `^6.2.0` to `^7.0.0`
- Fix some deprecated changes from Material Theme System Updates
- Fix a deprecated override of `buildViewportChrome`
(flutter/flutter#111715)
- Remove a unnecessary override

---------

Co-authored-by: Alex Li <github@alexv525.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @goderbauer