Skip to content

Remove deprecated drag anchor #111713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 19, 2022
Merged

Remove deprecated drag anchor #111713

auto-submit merged 2 commits into from
Sep 19, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 16, 2022 •
edited
Loading

This removes

  • Draggable.dragAnchor
  • LongPressDraggable.dragAnchor
  • DragAnchor enum

This deprecated class has reached end of life after the release of Flutter 3.3

Part of #111708
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-3-3

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Sep 16, 2022
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 16, 2022
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Sep 16, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Sep 16, 2022

Customers are migrated, this is safe to land.

@Piinks Piinks changed the title WIP - Remove deprecated drag anchor Remove deprecated drag anchor Sep 16, 2022
@Piinks Piinks requested review from Hixie and goderbauer September 16, 2022 22:37
goderbauer
goderbauer approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit 75d8fb3 into flutter:master Sep 19, 2022
This was referenced Sep 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
75d8fb3 Remove deprecated drag anchor (flutter/flutter#111713)
3d97c23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
75d8fb3 Remove deprecated drag anchor (flutter/flutter#111713)
d1ad710
@bernaferrari
Copy link
Contributor

bernaferrari commented Sep 20, 2022

Noob question: is it possible to remove this too?

2.3.0 seems to be more than one year ago. I'm not sure you have a calendar and periodically removes the deprecated things, or you are seeing some code and see it is deprecated, let's remove it.

image

image

@Piinks
Copy link
Contributor Author

Piinks commented Sep 20, 2022

That one is not slated for removal after v3.3. The cut-off was v2.2 this time around. The deprecation policy specifies number of releases, as well as time, with the longest duration as taking precedence, for removing deprecated code. That one should be removed in the next batch.

@bernaferrari
Copy link
Contributor

bernaferrari commented Sep 20, 2022

Oh, ok, thanks!!

@Piinks
Copy link
Contributor Author

Piinks commented Sep 20, 2022

Also, you do not seem to be referring to stable releases. Those are the releases we base the cut off on. 2.2 was followed by 2.5 on the stable channel. :)

@bernaferrari
Copy link
Contributor

bernaferrari commented Sep 20, 2022

You are right, but 2.5 was also more than 1 year ago (barely..) 😛

@Piinks
Copy link
Contributor Author

Piinks commented Sep 20, 2022 •
edited
Loading

but 2.5 was also more than 1 year ago
v2.5 9/8/2021
v3.3 8/30/2022

Again, this is based on release dates. Not today's date.
Do you feel we should change our policy? Feedback is always welcome.

@bernaferrari
Copy link
Contributor

bernaferrari commented Sep 20, 2022

No, it is fine the way it is, but I never understood it (I still don't understand it, lol). I guess it is 12month + 1 stable version, something like this.

@Piinks Piinks mentioned this pull request Sep 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @bernaferrari @goderbauer