Some miscellaneous changes found while making another PR #111620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
approved these changes
Sep 20, 2022
| <String, Object?>{ | ||
| 'id': 7, | ||
| 'label': 'Sub Sub Menu 100', | ||
| 'label': 'Sub Sub Menu 110', |
Contributor
There was a problem hiding this comment.
What's the reason for the change her? Just curious.
Contributor
Author
There was a problem hiding this comment.
It didn't match the numbering from the other ones. Basically, consistency.
This was referenced Sep 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are just some minor things I thought I'd fix that I found while working on the menu bar PR.
Swapped a couple of usages of
MaterialStateProperty.allforconst MaterialStatePropertyAll, and fixed an anomaly in the naming of some example code data, and added a macro to thechilddocs inButtonStyleButton.