Skip to content

Provide Material 3 defaults for vanilla Chip widget. #111597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 19, 2022
Merged

Provide Material 3 defaults for vanilla Chip widget. #111597

auto-submit merged 1 commit into from
Sep 19, 2022
+183 −16

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Sep 14, 2022 •
edited by HansMuller
Loading

Material 3 doesn't provide a "default" chip, but we have a Chip widget base class that some may be using. This PR just adds the 'Assist' chip's defaults for M3 to the base class.

Also optimized the code generation for shapes to make the rounded rect case a little cleaner.

Fixes: #109470

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 14, 2022
guidezpl
guidezpl approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

HansMuller
HansMuller approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Unfortunately the test failures appear to have been caused by this PR. Either the new defaults or the old tests will need fine tuning.

@darrenaustin darrenaustin added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit df110ef into flutter:master Sep 19, 2022
This was referenced Sep 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
df110ef Provide Material 3 defaults for vanilla Chip widget. (flutt…
1bcb7fb 
…er/flutter#111597)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
df110ef Provide Material 3 defaults for vanilla Chip widget. (flutt…
e4cbfcf 
…er/flutter#111597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Add M3 theming to vanilla Chip when opting in on useMaterial3

3 participants

@darrenaustin @HansMuller @guidezpl