Fix text direction nullability #111513
Fix text direction nullability #111513
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// This is a convenience method that creates a text painter with the supplied | ||
| /// parameters, lays it out with the supplied [minWidth] and [maxWidth], and | ||
| /// returns its [TextPainter.width] making sure to dispose the underlying | ||
| /// resources. |
There was a problem hiding this comment.
we should add something about how this is expensive
| /// returns its [TextPainter.width] making sure to dispose the underlying | ||
| /// resources. | ||
| /// | ||
| /// Unlike the [TextPainter] constructor, the [textDirection] parameter is |
There was a problem hiding this comment.
The grammar in this sentence is dubious (it implies "the constructor is not required"). In general I'm not sure as written that this paragraph really helps the reader understand what's happening.
I would instead say something like "The [text] and [textDirection] are required as they have no reasonable defaults." or even maybe just not say anything at all.
|
test-exempt: api change with no logic change |
|
auto label is removed for flutter/flutter, pr: 111513, due to - The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
See #111493 (comment)