Skip to content

Updated tokens to v0.127 #111495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 3 commits into from
Sep 14, 2022
Merged

Updated tokens to v0.127 #111495

QuncCccccc merged 3 commits into from
Sep 14, 2022

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Sep 13, 2022 •
edited
Loading

  • Updated the Material Design tokens to v0.127.
  • Added tokens for the Radio button.
  • New tokens are added to chips, colors, navigation drawer, and shape. Some tokens are removed from dialog, menu, and motion. Changes in Chips might be needed because Chips were using xx.with-icon.xx which are replaced with xx.with-leading-icon.xx and xx.with-trailing-icon.xx.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 13, 2022
@QuncCccccc QuncCccccc marked this pull request as ready for review September 13, 2022 18:46
guidezpl
guidezpl reviewed Sep 13, 2022
View reviewed changes
guidezpl
guidezpl reviewed Sep 13, 2022
View reviewed changes
HansMuller
HansMuller approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guidezpl
guidezpl reviewed Sep 14, 2022
View reviewed changes
@QuncCccccc QuncCccccc merged commit 23d1b15 into flutter:master Sep 14, 2022
This was referenced Sep 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
23d1b15 Updated tokens to v0.127 (flutter/flutter#111495)
88bddcd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
23d1b15 Updated tokens to v0.127 (flutter/flutter#111495)
238f383
TahaTesser
TahaTesser reviewed Sep 22, 2022
View reviewed changes
@TahaTesser TahaTesser mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser left review comments

@guidezpl guidezpl guidezpl approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@QuncCccccc @HansMuller @guidezpl @TahaTesser