Skip to content

Quiet iOS native test result zipping #111434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Sep 13, 2022
Merged

Quiet iOS native test result zipping #111434

auto-submit merged 3 commits into from
Sep 13, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 13, 2022 •
edited
Loading

Avoid hundreds of lines of zipping log spew when native iOS tests fail:

Example https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8803188107419461905/+/u/run_module_test_ios/test_stdout

[module_test_ios] [STDOUT] Executing "zip -r -9 /opt/s/w/ir/x/w/recipe_cleanup/flutter_logs_dir/module_test_ios-objc-2022-09-12T16:06:31.734361.zip result.xcresult" in "/opt/s/w/ir/x/t/flutter_module_test_ios_xcresult.3bZOZY" with environment {BOT: true, LANG: en_US.UTF-8}
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/ (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/ (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~-zNSZqYWtgVjjRs748aDZ2mLtOdrEY4-wFu6kq3Nr0v4MtCA09bkyCLGAPToicCsfBsY8E8EP4Bh_E89p0lFOg== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~VNMXCa5_T5tUIEy60wiW3O_0_cbmY-dT0re_GWd9QtTMfbL0xvS5y54CCUOHHSzUYweOhdnvdYv-hoNWxiHm8Q== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~Gtwb4A71w8AMG-rSejDEk8J-ysaS8wMwpzWk67kcdzJjornWSBv_TKX9dBMj10mtMrKmJjwaIV5XprdC8XAcPA== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~dt2w4vMNcWhz9Csu1zoSLKwWtDurLpgoqWFkXrBkdRbbOkOV500NCoVSouMg7gTtY1Yj8A9mCAIzbmF_3be8VA== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~qK1ES2CO6sjdZeIGImfXGdE_V6-ENVtm1ReBbmBXY4JTwQkGel-6mf4lWxKh1sTSo8lwfK1w-X9JO7Xy9pzxAQ== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~-_up9ToOSuB0RqBb3_HHEksbLnIlkGI8UjLaQnO2goUQY-ArC61nmlrpscfS1GRszv8FOBAl882qWLSJClW6HQ== (deflated 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~EQZQIcJuRJz32wiTAERZAV1oT4UQpP6ydEL4yHxVCvX9oYbdCRVPqLxN-wAMQDalQujP5RoUC9TSFo5lOUIm7w== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~QSgX9uYaSMwKItFJ4YfGscvEScgrWDAUoOCtId36LKt8QdXv8rTNAxPoQh9W7B6o1y8jNNr9skl0zt0DxnMm2g== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~ce5I-SM9wDoLACe77WjmP5Bw_D-dGR6-4kVp6MxZPzSGtPx_dZa3VqAKXjqR83t2aDHwPbEe3U1xGTdkKFx5ZQ== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~rg0xDzoau2aZw2gxLscJfRjsu_AoEEECWOrqXlXxeGAgBYDVZktMlSJA_XAh0i9ZlFeqsMpYnNHyZ7KLDDY1uw== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~XdY3wh-lIBjk5vSTkXcv4KhVoqx7kgkO5bYHzDSIg5ohzzjyZDuClzp3_FhlIH2kF9JIBowlI-oTqz6wrpj2dg== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~ITx0EaCXh4iFG9UlLH0Y5JoitMA4lBiZ_9s1-rML6cosUSbHBqiz0Kh1E5rdaGXtnQoOdQphRHpYqXlqQdetdA== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~N3TQOLBabir3izVYF4ld3lWPB5RjtgoXmgoQSWS_1ZFAePO9mSbGxlCwLt2S3O4MnCbKsthbu_rtNzZxm7pKyQ== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~Q2BC4HkosXIHDqv6ZK851TxORXJPvpszoFitksc9zh29bMbf14Vh5qeLSxLOkVHfffzEm16EoSO3fRyHaKZRcQ== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~5-vxt3hjzHQXdk-lkyrztWELx0EVaBi0NUwcUcPyCMQfD-Z8B0pNc1p3e-X3WrfIxaKsm0NB5SJdWxfelT6F-Q== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~1GKerG_rygfeqwQz16FfqMNnPbSXEhfsFmJuFAJR3pYxAbqQ7zzNgrNjrYUwqmOM1duLHTc8f0vwSTHziZf79g== (deflated 1%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~eN0BVKT0amWYkXACYSymSRo0Z4Y7VPxGNGx1ZiLMlbNYPA9d5V3sLE7KpyCMFk9LyFeY9zub758uEMahIG2PNg== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~a47HflJae0O8hSNNF3BCTLIMiSAsFxM5k0C5vXDMzI4uelLO6pd5nSY6p5FBgb8YMwhJqFFUygoc4Fut8hrsow== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~V2u64lqKVdiibYjw1nObz6fYbK0RWExJ_3PPLqhru9ul3yAbrw2caS74IdTDLc82bFl13MYgeo_mk1obf7hvug== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~qkSv5TQx_EuJVDyCtPN7pxSZfLwU18GetzV5ZT1iCv6kUEb8t4E0_gsRfHwdxhhJhfV5zIGZHnce4fw_SAg2Gg== (deflated 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~Z7m5ZblnyIzSolJlLhY2v2Nj3VYbCTbDVpEEWLaCJ7OWJTMvsPUpwDscxr_JtvYEAC1d4xcy82oXVWkD_5vCFw== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~LEeXZg3P1N4HXQNBY2nI3k7-WlyfMNwwsZuOUHUmfQ5m2pw9pd7pZkYFojyNUhdjHcbSYAnvzVLRS66VwpcYKQ== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~WdjfMBrWsQKAFVgr-R--TTPpiewJtYiYh_Lt6PGJwS229HpVtCZ5agUZD6Y1QFHPJNx1lt1K2InMzlpZRmiXKw== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~nju9euYEWG9P2EkRCY5s4XBWcW_LoIn58BKeiYIJ_Px--OKTsghI6-pmjQ4EjlIJiz9IoFynjft2znVvpUXFxw== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~FtCHrtzaU--LLLGOPGSEbqZGP-dt2XP2rM0LOyOQbWTKXXrNbHnSoOhqWnErpV9bGAd2A8bMX4Kz1TbHhw8yVA== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~DJeufrPoaHZbKaexfSeG7bQgt2btsPtvYykaVWMUQfrqy5X3uDmY_fqU-1vSw2YcOECoiEPJvx3bO_lnmRde_g== (deflated 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~PAp1WI_Kj3dtKhFk7bP0HscL4aAApj28q9Lo3f970YTuiEcddhkMS1GpuVmTpF0Ky0AnO2W657GfMiE6qw5g-Q== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~xytjfQ5no3-QpcuFqggL6MdlGmAL22_p_1DEYfDNDrUtJ0GYXQEIp6XlVHvn4oZvUI1T8cwiSj5JIvRbYZbC9Q== (stored 0%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/data.0~OQtQoLyJzmwHUsF93_Aesr5YO2RF9rQqlj9Y9VwKa40eE0mbotRPR6H_LNORwNg88OI16Ju-62nrOOYmouVMaw== (deflated 1%)
[module_test_ios] [STDOUT] stdout:   adding: result.xcresult/Data/refs.0~_dVsx1XdM9XBXAPdVgjjtbxNWduqa8xtQMh8RcijFK41rqDeOy47umnaCKltT7TDf8aoVguYIAjkUsjqqN3MSQ== (stored 0%)
.....

After this change it looks like:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8803175519294956977/+/u/run_module_test_ios/test_stdout

[module_test_ios] [STDOUT] Executing "zip -r -9 -q /opt/s/w/ir/x/w/recipe_cleanup/flutter_logs_dir/module_test_ios-objc-2022-09-12T19:32:31.728322.zip result.xcresult" in "/opt/s/w/ir/x/t/flutter_module_test_ios_xcresult.rbmbue" with environment {BOT: true, LANG: en_US.UTF-8}

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Sep 13, 2022
@jmagman jmagman self-assigned this Sep 13, 2022
jmagman
jmagman commented Sep 13, 2022
View reviewed changes
dev/devicelab/bin/tasks/module_test_ios.dart Outdated
);

if (testResultExit != 0) {
if (testResultExit == 0) {
Copy link
Member Author

@jmagman jmagman Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't check this in, but want a run that "fails" to see the zipping output.

@jmagman jmagman marked this pull request as ready for review September 13, 2022 21:44
christopherfujino
christopherfujino approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit auto-submit bot merged commit 489094a into flutter:master Sep 13, 2022
@jmagman jmagman deleted the quiet-zip branch September 13, 2022 23:10
This was referenced Sep 14, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
489094a Quiet iOS native test result zipping (flutter/flutter#111434)
ddbb31a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
489094a Quiet iOS native test result zipping (flutter/flutter#111434)
7ec5365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @christopherfujino