Create an enum for widget inspector service extensions for use by tools #111405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Sep 12, 2022
| final String? aId = service.toId(a, group1); | ||
| expect(service.toId(a, group2), equals(aId)); | ||
| expect(service.toId(a, group3), equals(aId)); | ||
| await service.testExtension('disposeGroup', <String, String>{'objectGroup': group1}); |
Member
Author
There was a problem hiding this comment.
no changes were made to this test other than formatting changes and replacing the usages of service extension strings with the new enum values.
This was referenced Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for service extensions that are part of the widgets library, but specific to the widget inspector.
Work towards #106502.
Related #110876, which added an enum for the Widgets library
Related #111146, which adds an enum for the foundation library
Related #111149, which adds an enum for the rendering library
Related #111222, which adds an enum for the scheduler library
Related #111271, which adds an enum for the services library
Related to flutter/devtools#4213, which tracks the task of using these values in DevTools and duplicating our copy of these strings.