Instrument State, Layer, RenderObject and Element. #111328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Sep 19, 2022
packages/flutter/test_release/foundation/memory_allocations_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter/test_release/foundation/memory_allocations_test.dart
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Sep 20, 2022
| MemoryAllocations.instance.dispatchObjectCreated( | ||
| library: _flutterFoundationLibrary, | ||
| className: 'ValueNotifier', | ||
| className: '$ValueNotifier', |
Contributor
There was a problem hiding this comment.
Do these end up being equivalent to runtimeType.toString under the hood?
Contributor
There was a problem hiding this comment.
Looks like, no, it's emitted as a TypeLiteralConstant which should be fine...
dnfield
approved these changes
Sep 20, 2022
This was referenced Sep 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flutter/devtools#3951