Skip to content

[flutter_tools] filter "Resolving dependencies..." from dart pub get output to fix test flakiness #111312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 10, 2022
Merged

[flutter_tools] filter "Resolving dependencies..." from dart pub get output to fix test flakiness #111312

auto-submit merged 2 commits into from
Sep 10, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 9, 2022 •
edited
Loading

Fixes #111272

Example failing build: https://ci.chromium.org/p/flutter/builders/prod/Linux%20tool_tests_commands/7002

Received "RangeError (index): Invalid value: Valid value range is empty: -1" while trying to parse:

Resolving dependencies...

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 9, 2022
Jasguerrero
Jasguerrero approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2022
keyonghan
keyonghan approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 9, 2022

auto label is removed for flutter/flutter, pr: 111312, due to - The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 9, 2022

I'm "lucky", it failed again :)

https://ci.chromium.org/p/flutter/builders/try/Mac%20tool_tests_commands/22616?

Received "RangeError (index): Invalid value: Valid value range is empty: -1" while trying to parse:

Got dependencies!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2022
@auto-submit auto-submit bot merged commit e4a203b into flutter:master Sep 10, 2022
This was referenced Sep 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
3a07c84 
…pub get output to fix test flakiness (flutter/flutter#111312)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
8d2bf75 
…pub get output to fix test flakiness (flutter/flutter#111312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
1f65e66 
…pub get output to fix test flakiness (flutter/flutter#111312)
@christopherfujino christopherfujino deleted the fix-analyze-integration-test branch September 10, 2022 17:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 11, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
cba83e0 
…pub get output to fix test flakiness (flutter/flutter#111312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
2e41803 
…pub get output to fix test flakiness (flutter/flutter#111312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
b17555c 
…pub get output to fix test flakiness (flutter/flutter#111312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
9fcb67d 
…pub get output to fix test flakiness (flutter/flutter#111312)
@jmagman jmagman mentioned this pull request Sep 13, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
e4a203b [flutter_tools] filter "Resolving dependencies..." from dart …
f925e16 
…pub get output to fix test flakiness (flutter/flutter#111312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

2 more reviewers

@Jasguerrero Jasguerrero Jasguerrero approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shard tool_tests_commands is severe flaky at test create_test

3 participants

@christopherfujino @Jasguerrero @keyonghan